Skip to content

Commit c57e402

Browse files
committed
chore: more 3.8+ changes
Signed-off-by: Henry Schreiner <[email protected]>
1 parent 9df0b29 commit c57e402

File tree

48 files changed

+90
-131
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+90
-131
lines changed

.github/CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ build-backend = "scikit_build_core.build"
241241
[project]
242242
name = "cmake_example"
243243
version = "0.0.1"
244-
requires-python = ">=3.7"
244+
requires-python = ">=3.8"
245245

246246
[project.optional-dependencies]
247247
test = ["pytest>=6.0"]
@@ -275,7 +275,7 @@ setup(
275275
cmake_source_dir=".",
276276
zip_safe=False,
277277
extras_require={"test": ["pytest>=6.0"]},
278-
python_requires=">=3.7",
278+
python_requires=">=3.8",
279279
)
280280
```
281281

.github/workflows/ci.yml

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,6 @@ jobs:
9696
- python-version: "3.8"
9797
runs-on: ubuntu-22.04
9898
cmake-version: "3.15.x"
99-
exclude:
100-
- python-version: "3.7"
101-
runs-on: ubuntu-latest
102-
cmake-version: "3.15.x"
10399

104100
steps:
105101
- uses: actions/checkout@v4
@@ -112,23 +108,18 @@ jobs:
112108
allow-prereleases: true
113109

114110
- uses: astral-sh/setup-uv@v5
115-
if:
116-
matrix.python-version != '3.7' && matrix.python-version != 'pypy-3.8'
117-
&& matrix.python-version != 'pypy-3.7'
111+
if: matrix.python-version != 'pypy-3.8'
118112

119113
- name: Install package (uv)
120-
if:
121-
matrix.python-version != '3.7' && matrix.python-version != 'pypy-3.8'
122-
&& matrix.python-version != 'pypy-3.7'
114+
if: matrix.python-version != 'pypy-3.8'
123115
run:
124116
uv pip install
125117
-e.[test,test-meta,test-numpy,test-schema,test-hatchling,wheels,cov,wheel-free-setuptools]
126118
--system
127119

128120
- name: Install package (pip)
129121
if:
130-
matrix.python-version == '3.7' || matrix.python-version == 'pypy-3.8'
131-
|| matrix.python-version == 'pypy-3.7'
122+
matrix.python-version == 'pypy-3.8'
132123
run:
133124
pip install
134125
-e.[test,test-meta,test-numpy,test-schema,wheels,cov,wheel-free-setuptools]

.pre-commit-config.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,8 @@ repos:
7676
- cmake
7777
- exceptiongroup
7878
- hatch-fancy-pypi-readme>=24
79-
- importlib-metadata>=6.6.0
8079
- importlib-resources
81-
- markdown-it-py<3 # Python 3.7 compat needed for mypy check
80+
- markdown-it-py
8281
- ninja
8382
- nox
8483
- orjson

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ features over classic Scikit-build:
7070
The following limitations are present compared to classic scikit-build:
7171

7272
- The minimum supported CMake is 3.15
73-
- The minimum supported Python is 3.7
73+
- The minimum supported Python is 3.8 (3.7+ for 0.10.x and older)
7474

7575
Some known missing features that will be developed soon:
7676

@@ -218,7 +218,7 @@ sdist.cmake = false
218218
wheel.packages = ["src/<package>", "python/<package>", "<package>"]
219219

220220
# The Python tags. The default (empty string) will use the default Python
221-
# version. You can also set this to "cp37" to enable the CPython 3.7+ Stable ABI
221+
# version. You can also set this to "cp38" to enable the CPython 3.8+ Stable ABI
222222
# / Limited API (only on CPython and if the version is sufficient, otherwise
223223
# this has no effect). Or you can set it to "py3" or "py2.py3" to ignore Python
224224
# ABI compatibility. The ABI tag is inferred from this tag.

docs/cmakelists.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ in your `pyproject.toml`:
123123

124124
```toml
125125
[tool.scikit-build]
126-
wheel.py-api = "cp37"
126+
wheel.py-api = "cp38"
127127
```
128128

129129
When you do that, `${SKBUILD_SABI_COMPONENT}` will be set to

docs/configuration.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ the wheel tags for the version you support:
352352

353353
```toml
354354
[tool.scikit-build]
355-
wheel.py-api = "cp37"
355+
wheel.py-api = "cp38"
356356
```
357357

358358
Scikit-build-core will only target ABI3 if the version of Python is equal to or
@@ -698,8 +698,8 @@ configuration. Recommendations:
698698
Known limitations:
699699

700700
- Resources (via `importlib.resources`) are not properly supported (yet).
701-
Currently experimentally supported except on Python 3.9 (3.7, 3.8, 3.10, 3.11,
702-
and 3.12 work). `importlib_resources` may work on Python 3.9.
701+
Currently experimentally supported except on Python 3.9 (3.8, 3.10, 3.11,
702+
3.12, and 3.13 work). `importlib_resources` may work on Python 3.9.
703703

704704
```console
705705
# Very experimental rebuild on initial import feature

docs/examples/downstream/pybind11_example/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
| pip builds | [![Pip Actions Status][actions-pip-badge]][actions-pip-link] |
99

1010
An example project built with [pybind11](https://github.com/pybind/pybind11) and
11-
scikit-build-core. Python 3.7+ (see older commits for older versions of Python).
11+
scikit-build-core. Python 3.8+ (see older commits for older versions of Python).
1212

1313
[gitter-badge]: https://badges.gitter.im/pybind/Lobby.svg
1414
[gitter-link]: https://gitter.im/pybind/Lobby

docs/examples/downstream/pybind11_example/pyproject.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,17 @@ readme = "README.md"
1111
authors = [
1212
{ name = "My Name", email = "[email protected]" },
1313
]
14-
requires-python = ">=3.7"
14+
requires-python = ">=3.8"
1515
classifiers = [
1616
"Development Status :: 4 - Beta",
1717
"License :: OSI Approved :: MIT License",
1818
"Programming Language :: Python :: 3 :: Only",
19-
"Programming Language :: Python :: 3.7",
2019
"Programming Language :: Python :: 3.8",
2120
"Programming Language :: Python :: 3.9",
2221
"Programming Language :: Python :: 3.10",
2322
"Programming Language :: Python :: 3.11",
23+
"Programming Language :: Python :: 3.12",
24+
"Programming Language :: Python :: 3.13",
2425
]
2526

2627
[project.optional-dependencies]

docs/examples/getting_started/abi3/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ find_package(
66
COMPONENTS Interpreter Development.SABIModule
77
REQUIRED)
88

9-
python_add_library(example MODULE example.c WITH_SOABI USE_SABI 3.7)
9+
python_add_library(example MODULE example.c WITH_SOABI USE_SABI 3.8)
1010

1111
install(TARGETS example DESTINATION .)

docs/examples/getting_started/abi3/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ name = "example"
77
version = "0.0.1"
88

99
[tool.scikit-build-core]
10-
wheel.py-api = "cp37"
10+
wheel.py-api = "cp38"

0 commit comments

Comments
 (0)