fix: expand some variables when constructing paths (#844)

Trying a potential fix for #843.

Signed-off-by: Henry Schreiner <[email protected]>

Author: henryiii

src/scikit_build_core/program_search.py

@@ -2,6 +2,7 @@
 
 import contextlib
 import json
+import os.path
 import shutil
 import subprocess
 from pathlib import Path
@@ -52,7 +53,7 @@ def _get_cmake_path(*, module: bool = True) -> Generator[Path, None, None]:
     for candidate in candidates:
         cmake_path = shutil.which(candidate)
         if cmake_path is not None:
-            yield Path(cmake_path)
+            yield Path(os.path.expandvars(cmake_path))
 
 
 def _get_ninja_path(*, module: bool = True) -> Generator[Path, None, None]:
@@ -71,7 +72,7 @@ def _get_ninja_path(*, module: bool = True) -> Generator[Path, None, None]:
     for candidate in candidates:
         ninja_path = shutil.which(candidate)
         if ninja_path is not None:
-            yield Path(ninja_path)
+            yield Path(os.path.expandvars(ninja_path))
 
 
 def get_cmake_program(cmake_path: Path) -> Program:
@@ -156,7 +157,7 @@ def get_make_programs() -> Generator[Path, None, None]:
     for candidate in candidates:
         make_path = shutil.which(candidate)
         if make_path is not None:
-            yield Path(make_path)
+            yield Path(os.path.expandvars(make_path))
 
 
 def best_program(

tests/test_cmake_config.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import os
+import os.path
 import shutil
 from pathlib import Path
 from typing import TYPE_CHECKING
@@ -15,7 +16,7 @@
 if TYPE_CHECKING:
     from collections.abc import Generator
 
-DIR = Path(__file__).parent.resolve()
+DIR = Path(os.path.expandvars(__file__)).parent.resolve()
 
 
 def configure_args(config: CMaker, *, init: bool = False) -> Generator[str, None, None]: