Skip to content

Conversation

@LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Apr 23, 2025

This would make it easier to cross-reference. I was debating going for an auto-generated one and integrating with sphinx directly or going with the nox -t gen files, and I think I prefer the latter because it makes it more obvious to review the generated text in all the places, wdyt?

I also want to unlock usage of sphinx roles in it, but the readme generation gets in the way. My opinion is that if we have this, we could either move the readme part to the generated page, or truncate it to only display the first summary sentence similar to how click does it.

Depends-on: #1051
Closes #999

@LecrisUT LecrisUT requested a review from henryiii April 23, 2025 15:48
@LecrisUT LecrisUT force-pushed the doc/config-ref branch 3 times, most recently from b07e098 to 9c8ab10 Compare April 25, 2025 14:03
@LecrisUT LecrisUT force-pushed the doc/config-ref branch 2 times, most recently from ca51653 to d022b75 Compare May 2, 2025 18:23
@henryiii
Copy link
Collaborator

henryiii commented May 5, 2025

Truncating for the readme sounds good. Generating it into the files seems fine. I don't really like the page name, though. "Configurations" (when we have a "Configuration" already) seems odd. I think it should either match or be clearly different, like "Configuration reference".

@LecrisUT
Copy link
Collaborator Author

LecrisUT commented May 5, 2025

I don't really like the page name, though. "Configurations" (when we have a "Configuration" already) seems odd. I think it should either match or be clearly different, like "Configuration reference".

Naming is the nemesis of a developer 😉. I will try to see if Configuration reference fits for the TOC menu at the left of the page. If not should we go with Config reference?

@henryiii
Copy link
Collaborator

henryiii commented May 5, 2025

That's fine, I just didn't like Configuration vs. Configurations, feel free to come up with some other variation, or even just match the names if that doesn't work.

@LecrisUT LecrisUT force-pushed the doc/config-ref branch 2 times, most recently from 3d3b162 to 0f46489 Compare May 5, 2025 16:58
@henryiii henryiii merged commit 121143d into scikit-build:main May 6, 2025
64 checks passed
@henryiii henryiii changed the title doc: Generate config value reference docs: generate config value reference May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autogenerate configuration reference

2 participants