fix: support overriding renamed options #1054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
mgorny
added a commit
to mgorny/gentoo
that referenced
this pull request
Aug 2, 2025
Once again switch to the newer scikit-build-core `build.verbose` option to fix compatibility with packages requiring the newer version, and let us stop patching ebuilds. Upstream fixed the behavior to allow using newer options in `config_settings`. Bug: scikit-build/scikit-build-core#912 Pull-Request: scikit-build/scikit-build-core#1054 Signed-off-by: Michał Górny <[email protected]>
mgorny
added a commit
to mgorny/gentoo
that referenced
this pull request
Aug 2, 2025
Once again switch to the newer scikit-build-core `build.verbose` option to fix compatibility with packages requiring the newer version, and let us stop patching ebuilds. Upstream fixed the behavior to allow using newer options in `config_settings`. Bug: scikit-build/scikit-build-core#912 Pull-Request: scikit-build/scikit-build-core#1054 Signed-off-by: Michał Górny <[email protected]>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Aug 9, 2025
Once again switch to the newer scikit-build-core `build.verbose` option to fix compatibility with packages requiring the newer version, and let us stop patching ebuilds. Upstream fixed the behavior to allow using newer options in `config_settings`. Bug: scikit-build/scikit-build-core#912 Pull-Request: scikit-build/scikit-build-core#1054 Signed-off-by: Michał Górny <[email protected]> Part-of: #43299 Signed-off-by: Michał Górny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #912.
Now envvar and config options won't trigger the error, only statically defined ones will. And you can override a static option with the renamed new option.
Also minor fix for a missing
env=envpassthrough for the API.