Skip to content

chore: add a few ruff checks #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henryiii merged 1 commit into from
Nov 6, 2025
Merged

chore: add a few ruff checks #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,21 +276,24 @@ extend-select = [
"UP", # pyupgrade
"YTT", # flake8-2020
"FURB", # refurb
"SLOT", # flake8-slots
"DTZ", # flake8-datetimez
"FA", # flake8-future-annotations
]
ignore = [
"PLE1205", # Format check doesn't work with our custom logger
"PT013", # It's correct to import classes for typing!
"RUF009", # Too easy to get a false positive
"PYI025", # Wants Set to be renamed AbstractSet
"ANN401", # Disallow dynamically typed expressions
"ISC001", # Conflicts with formatter
"PLC0415", # Import should be at top of file
"PLE1205", # Format check doesn't work with our custom logger
"PLR09", # Too many ...
"PLR2004", # Magic value used in comparison
"PLC0415", # Import should be at top of file
"ANN401", # Disallow dynamically typed expressions
"PT013", # It's correct to import classes for typing!
"PYI025", # Wants Set to be renamed AbstractSet
"RUF009", # Too easy to get a false positive
"S101", # Use of assert detected
"S404", # subprocess module is possibly insecure
"S603", # subprocess untrusted input
"S607", # subprocess call
"S404", # subprocess module is possibly insecure
]
typing-modules = ["scikit_build_core._compat.typing"]

Expand Down Expand Up @@ -323,9 +326,11 @@ known-local-folder = ["pathutils"]
"noxfile.py" = ["T20", "TID251"]
"src/scikit_build_core/resources/*.py" = ["PTH", "ARG002", "FBT", "TID251"]
"src/scikit_build_core/_compat/**.py" = ["TID251"]
"src/scikit_build_core/settings/**.py" = ["FBT001"]
"src/scikit_build_core/settings/**.py" = ["FBT001", "FA"]
"src/scikit_build_core/file_api/**.py" = ["FA"]
"tests/conftest.py" = ["TID251"]
"tests/packages/**.py" = ["TID251"]
"tests/test_settings.py" = ["FA"]
"docs/conf.py" = ["TID251"]
"docs/examples/**" = ["ANN"]
"src/scikit_build_core/file_api/model/*.py" = ["N"]
Expand Down
2 changes: 2 additions & 0 deletions src/scikit_build_core/settings/skbuild_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ class CMakeSettingsDefine(str):
to the CMake representation in the `cmake.define` settings key.
"""

__slots__ = ()

json_schema = Union[str, bool, List[str]]

def __new__(cls, raw: Union[str, bool, List[str]]) -> "CMakeSettingsDefine":
Expand Down