Skip to content

Commit e6e27d6

Browse files
authored
Adding Python 3.8 (#145)
* Adding Python 3.8 * Fix build with 3.8 * Dropping 3.8 from manylinux1
1 parent a17e92f commit e6e27d6

File tree

5 files changed

+20
-1
lines changed

5 files changed

+20
-1
lines changed

.ci/azure-build-pipeline.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,8 @@ jobs:
6666
python.version: '3.6'
6767
Python37:
6868
python.version: '3.7'
69+
Python38:
70+
python.version: '3.8'
6971
pool:
7072
vmImage: 'macOS-10.14'
7173
steps:

.ci/build-wheels.sh

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,20 @@ set -e -x
44
# Collect the pythons
55
pys=(/opt/python/*/bin)
66

7+
# Print list of Python's available
8+
echo "All Pythons: ${pys[@]}"
9+
710
# Filter out Python 3.4
811
pys=(${pys[@]//*34*/})
912

13+
# Filter out Python 3.8 on manylinux1
14+
if [[ $PLAT =~ "manylinux1" ]]; then
15+
pys=(${pys[@]//*38*/})
16+
fi
17+
18+
# Print list of Python's being used
19+
echo "Using Pythons: ${pys[@]}"
20+
1021
# Compile wheels
1122
for PYBIN in "${pys[@]}"; do
1223
"${PYBIN}/pip" install -r /io/dev-requirements.txt

.ci/macos-install-python.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ case $PYTHON_VERSION in
1212
3.7)
1313
FULL_VERSION=3.7.3
1414
;;
15+
3.8)
16+
FULL_VERSION=3.8.0
17+
;;
1518
esac
1619

1720
INSTALLER_NAME=python-$FULL_VERSION-macosx10.9.pkg

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,6 @@ First beta release and beginning of the changelog.
66

77
* Unlimited storage does not support pickling or classic multiprocessing
88
* Some non-simple storages do not support some forms of access, like `.view`
9+
* Indexing and the array versions (such as centers) are incomplete and subject to change
10+
* The numpy module is provisional and subject to change
11+
* Docstrings and signatures will improve in later versions (especially on Python 3)

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Python bindings for [Boost::Histogram][] ([source][Boost::Histogram source]), a
1515

1616
## Installation
1717

18-
This library is under development, but you can install directly from GitHub if you would like. You need a C++14 compiler and Python 2.7--3.7. Boost 1.71 is not required or needed (this only depends on included header-only dependencies).
18+
This library is under development, but you can install directly from GitHub if you would like. You need a C++14 compiler and Python 2.7--3.8. Boost 1.71 is not required or needed (this only depends on included header-only dependencies).
1919
All the normal best-practices for Python apply; you should be in a virtual environment, otherwise add `--user`, etc.
2020

2121
```bash

0 commit comments

Comments
 (0)