chore: add ruff PERF (#649)

Signed-off-by: Henry Schreiner <[email protected]>
Co-authored-by: Andrzej Novak <[email protected]>

Author: henryiii

pyproject.toml

@@ -147,6 +147,7 @@ markers = [
 extend-select = [
     "B", # flake8-bugbear
     "I", # isort
+    "PERF", # perflint
     "ARG", # flake8-unused-arguments
     "C4", # flake8-comprehensions
     "EM", # flake8-errmsg

src/mplhep/_dev.py

@@ -163,8 +163,7 @@ def _find_files_to_clean(self) -> list[Path]:
         for target in cleanup_targets:
             if "*" in target:
                 # Handle glob patterns
-                for item in self.project_root.glob(target):
-                    items_to_clean.append(item)
+                items_to_clean.extend(self.project_root.glob(target))
             else:
                 item = self.project_root / target
                 if item.exists():
@@ -336,7 +335,7 @@ def cmd_precommit(self, extra_args: list[str] | None = None) -> bool:
                     self._print_success(
                         f"Removed {item.relative_to(self.project_root)}"
                     )
-            except OSError as e:
+            except OSError as e:  # noqa: PERF203
                 self._print_error(f"Failed to remove {item}: {e}")
 
         if len(items_to_clean) > 10:
@@ -477,7 +476,7 @@ def cmd_clean(self) -> bool:
                     self._print_success(
                         f"Removed {item.relative_to(self.project_root)}"
                     )
-            except OSError as e:
+            except OSError as e:  # noqa: PERF203
                 self._print_error(f"Failed to remove {item}: {e}")
 
         if len(items_to_clean) > 10:
@@ -710,10 +709,11 @@ def _get_available_baselines(self) -> list[str]:
         if not benchmark_dir.exists():
             return []
 
-        baselines = []
-        for item in benchmark_dir.iterdir():
-            if item.is_dir() and not item.name.startswith("."):
-                baselines.append(item.name)
+        baselines = [
+            item.name
+            for item in benchmark_dir.iterdir()
+            if item.is_dir() and not item.name.startswith(".")
+        ]
 
         return sorted(baselines)
 
@@ -724,12 +724,12 @@ def _get_available_benchmark_files(self) -> list[str]:
         if not benchmark_dir.exists():
             return []
 
-        benchmark_files = []
-        for subdir in benchmark_dir.iterdir():
-            if subdir.is_dir() and not subdir.name.startswith("."):
-                for json_file in subdir.glob("*.json"):
-                    # Use just the filename without extension for comparison
-                    benchmark_files.append(json_file.stem)
+        benchmark_files = [
+            json_file.stem
+            for subdir in benchmark_dir.iterdir()
+            if subdir.is_dir() and not subdir.name.startswith(".")
+            for json_file in subdir.glob("*.json")
+        ]
 
         return sorted(benchmark_files)
 
@@ -838,15 +838,15 @@ def _get_choice(
         for i, (label, _) in enumerate(choices, 1):
             print(f"  {i}. {label}")
 
-        while True:
-            try:
+        try:
+            while True:
                 response = input("Enter choice (number): ").strip()
                 idx = int(response) - 1
                 if 0 <= idx < len(choices):
                     return choices[idx][1]
                 print(f"Please enter a number between 1 and {len(choices)}")
-            except (ValueError, KeyboardInterrupt):
-                return None
+        except (ValueError, KeyboardInterrupt):
+            return None
 
     def _check_tool_available(self, tool_name: str, check_cmd: list[str]) -> bool:
         """Check if a tool is available."""

src/mplhep/_utils.py

@@ -264,11 +264,9 @@ def _get_plottables(
     final_bins, _ = _get_plottable_protocol_bins(hists[0].axes[0])
 
     if xoffsets is True:
-        parsed_offsets = []
         widths = np.diff(final_bins)
         sub_bin_width = widths / (len(hists) + 1)
-        for i in range(len(hists)):
-            parsed_offsets.append(sub_bin_width * (i + 1))
+        parsed_offsets = [sub_bin_width * (i + 1) for i in range(len(hists))]
         xoffsets = parsed_offsets
     else:
         xoffsets = [None] * len(hists)
@@ -1128,9 +1126,11 @@ def _overlap(ax, bboxes, get_vertices=False, exclude_texts=None):
                         lines_display.append(interpolated_display)
 
     # Collect bboxes from texts (excluding specified text objects to avoid self-overlap)
-    for handle in ax.texts:
-        if isinstance(handle, Text) and handle not in exclude_texts:
-            bboxes_display.append(handle.get_window_extent())
+    bboxes_display.extend(
+        handle.get_window_extent()
+        for handle in ax.texts
+        if isinstance(handle, Text) and handle not in exclude_texts
+    )
 
     # Concatenate all vertices in display coordinates
     all_vertices_display = (
@@ -1411,8 +1411,6 @@ def _draw_text_bbox(ax):
         return [], []
 
     fig.canvas.draw()
-    bboxes = []
-    for box in textboxes:
-        bboxes.append(box.get_tightbbox(fig.canvas.renderer))
+    bboxes = [box.get_tightbbox(fig.canvas.renderer) for box in textboxes]
     logger.debug(f"_draw_text_bbox: Returning {len(bboxes)} bboxes")
     return bboxes, textboxes

src/mplhep/plot.py

@@ -415,9 +415,7 @@ def histplot(
     def iterable_not_string(arg):
         return isinstance(arg, collections.abc.Iterable) and not isinstance(arg, str)
 
-    _chunked_kwargs: list[dict[str, Any]] = []
-    for _ in range(len(hists)):
-        _chunked_kwargs.append({})
+    _chunked_kwargs: list[dict[str, Any]] = [{} for _ in hists]
     for kwarg, kwarg_content in kwargs.items():
         # Check if iterable
         if iterable_not_string(kwarg_content):
@@ -486,9 +484,7 @@ def iterable_not_string(arg):
         _labels = _labels[::-1]
         if "color" not in kwargs or kwargs.get("color") is None:
             # Inverse default color cycle
-            _colors = []
-            for _ in range(len(plottables)):
-                _colors.append(ax._get_lines.get_next_color())  # type: ignore[attr-defined]
+            _colors = [ax._get_lines.get_next_color() for _ in plottables]  # type: ignore[attr-defined]
             _colors.reverse()
             for i in range(len(plottables)):
                 _chunked_kwargs[i].update({"color": _colors[i]})

tests/test_basic.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import itertools
 import os
 import re
 
@@ -274,12 +275,7 @@ def test_histplot_type_flow():
 
 @pytest.mark.mpl_image_compare(style="default")
 def test_hist2dplot_hist_all_flow_show():
-    flow_opts = []
-    for ufl1 in [True, False]:
-        for ofl1 in [True, False]:
-            for ufl2 in [True, False]:
-                for ofl2 in [True, False]:
-                    flow_opts.append([ufl1, ofl1, ufl2, ofl2])
+    flow_opts = [list(p) for p in itertools.product([True, False], repeat=4)]
 
     np.random.seed(0)
     _fill = np.random.normal(2.5, 2, 10000).reshape(-1, 2).T
@@ -302,12 +298,7 @@ def test_hist2dplot_hist_all_flow_show():
 
 @pytest.mark.mpl_image_compare(style="default")
 def test_hist2dplot_hist_all_flow_hint():
-    flow_opts = []
-    for ufl1 in [True, False]:
-        for ofl1 in [True, False]:
-            for ufl2 in [True, False]:
-                for ofl2 in [True, False]:
-                    flow_opts.append([ufl1, ofl1, ufl2, ofl2])
+    flow_opts = [list(p) for p in itertools.product([True, False], repeat=4)]
 
     np.random.seed(0)
     _fill = np.random.normal(2.5, 2, 10000).reshape(-1, 2).T