use context managers in notebooks

Author: matthewfeickert

docs/examples/notebooks/ImpactPlot.ipynb

@@ -76,14 +76,11 @@
    "outputs": [],
    "source": [
     "def make_model(channel_list):\n",
-    "    spec = json.load(\n",
-    "        open(\"1Lbb-probability-models/RegionA/BkgOnly.json\", encoding=\"utf-8\")\n",
-    "    )\n",
-    "    patchset = pyhf.PatchSet(\n",
-    "        json.load(\n",
-    "            open(\"1Lbb-probability-models/RegionA/patchset.json\", encoding=\"utf-8\")\n",
-    "        )\n",
-    "    )\n",
+    "    with open(\"1Lbb-probability-models/RegionA/BkgOnly.json\", encoding=\"utf-8\") as spec_file:\n",
+    "        spec = json.load(spec_file)\n",
+    "    with open(\"1Lbb-probability-models/RegionA/patchset.json\", encoding=\"utf-8\") as patchset_file:\n",
+    "        patchset = pyhf.PatchSet(json.load(patchset_file))\n",
+    "\n",
     "    patch = patchset[\"sbottom_750_745_60\"]\n",
     "    spec = jsonpatch.apply_patch(spec, patch)\n",
     "    spec[\"channels\"] = [c for c in spec[\"channels\"] if c[\"name\"] in channel_list]\n",

docs/examples/notebooks/multiBinPois.ipynb

@@ -85,7 +85,8 @@
     }
    ],
    "source": [
-    "source = json.load(open(validation_datadir + \"/1bin_example1.json\", encoding=\"utf-8\"))\n",
+    "with open(validation_datadir + \"/1bin_example1.json\", encoding=\"utf-8\") as source_file:\n",
+    "    source = json.load(source_file)\n",
     "model = uncorrelated_background(\n",
     "    source['bindata']['sig'], source['bindata']['bkg'], source['bindata']['bkgerr']\n",
     ")\n",

docs/examples/notebooks/multichannel-coupled-histo.ipynb

@@ -165,10 +165,8 @@
     }
    ],
    "source": [
-    "with open(\n",
-    "    validation_datadir + \"/2bin_2channel_coupledhisto.json\", encoding=\"utf-8\"\n",
-    ") as spec:\n",
-    "    source = json.load(spec)\n",
+    "with open(validation_datadir + \"/2bin_2channel_coupledhisto.json\", encoding=\"utf-8\") as source_file:\n",
+    "    source = json.load(source_file)\n",
     "\n",
     "data, pdf = prep_data(source[\"channels\"])\n",
     "\n",

docs/examples/notebooks/pullplot.ipynb

@@ -76,6 +76,7 @@
     "        \"1Lbb-probability-models/RegionA/BkgOnly.json\", encoding=\"utf-8\"\n",
     "    ) as spec_file:\n",
     "        spec = json.load(spec_file)\n",
+    "\n",
     "    spec[\"channels\"] = [c for c in spec[\"channels\"] if c[\"name\"] in channel_list]\n",
     "    spec[\"measurements\"][0][\"config\"][\"poi\"] = \"lumi\"\n",
     "\n",