chore: Specify exceptions to remove inline ignores of E722 (#1194)

* Specify exception for all exception cases
* Remove all inline noqa: E722
   - E722: Do not use bare except, specify exception instead

Author: matthewfeickert

src/pyhf/pdf.py

@@ -731,9 +731,10 @@ def logpdf(self, pars, data):
             ):  # force to be not scalar, should we changed with #522
                 return tensorlib.reshape(result, (1,))
             return result
-        except:  # noqa: E722
+        except Exception:
             log.error(
-                f'eval failed for data {tensorlib.tolist(data)} pars: {tensorlib.tolist(pars)}'
+                f"Eval failed for data {tensorlib.tolist(data)} pars: {tensorlib.tolist(pars)}",
+                exc_info=True,
             )
             raise
 

tests/test_init.py

@@ -41,7 +41,7 @@ def test_missing_backends(isolate_modules, param):
 
     try:
         delattr(pyhf.tensor, module_name)
-    except:  # noqa: E722
+    except AttributeError:
         pass
 
     with expectation:
@@ -80,7 +80,7 @@ def test_missing_optimizer(isolate_modules, param):
     )
     try:
         delattr(pyhf.optimize, module_name)
-    except:  # noqa: E722
+    except AttributeError:
         pass
 
     with expectation: