Skip to content

Commit d825d5a

Browse files
build: Update lower bound on iminuit to v2.7.0 (#1895)
* Update lower bound on iminuit to v2.7.0 as it is the 'oldest' SemVer release that has the behavior: > Minuit.hesse no longer sets the status of the FunctionMinimum unconditionally > to valid if it was invalid before. Without this fix, the situation can arise where `Minuit.hesse()` can cause `Minuit.valid` to be True when it should be False. * Update tests/constraints.txt to use iminuit==2.7.0. * Amends PR #1845
1 parent 2411ed3 commit d825d5a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
'torch': ['torch>=1.10.0'], # c.f. PR #1657
1010
'jax': ['jax>=0.2.10', 'jaxlib>=0.1.60,!=0.1.68'], # c.f. Issue 1501
1111
'xmlio': ['uproot>=4.1.1'], # c.f. PR #1567
12-
'minuit': ['iminuit>=2.4.0'], # c.f. PR #1306
12+
'minuit': ['iminuit>=2.7.0'], # c.f. PR #1895
1313
}
1414
extras_require['backends'] = sorted(
1515
set(

tests/constraints.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ importlib_resources==1.3.0
99
# xmlio
1010
uproot==4.1.1
1111
# minuit
12-
iminuit==2.4.0
12+
iminuit==2.7.0 # c.f. PR #1895
1313
# tensorflow
1414
tensorflow==2.6.5 # c.f. PR #1874
1515
tensorflow-probability==0.11.0 # c.f. PR #1657

0 commit comments

Comments
 (0)