refactor: Drop 'modifier' from parameter set requirements (#1189)

* Drop the modifier from required_parset()
   - Parameter set requirements do not need to know modifier

Author: kratsg

src/pyhf/modifiers/histosys.py

@@ -15,7 +15,6 @@ def required_parset(cls, sample_data, modifier_data):
         return {
             'paramset_type': constrained_by_normal,
             'n_parameters': 1,
-            'modifier': cls.__name__,
             'is_constrained': cls.is_constrained,
             'is_shared': True,
             'inits': (0.0,),

src/pyhf/modifiers/lumi.py

@@ -14,7 +14,6 @@ def required_parset(cls, sample_data, modifier_data):
         return {
             'paramset_type': constrained_by_normal,
             'n_parameters': 1,
-            'modifier': cls.__name__,
             'is_constrained': cls.is_constrained,
             'is_shared': True,
             'op_code': cls.op_code,

src/pyhf/modifiers/normfactor.py

@@ -14,7 +14,6 @@ def required_parset(cls, sample_data, modifier_data):
         return {
             'paramset_type': unconstrained,
             'n_parameters': 1,
-            'modifier': cls.__name__,
             'is_constrained': cls.is_constrained,
             'is_shared': True,
             'inits': (1.0,),

src/pyhf/modifiers/normsys.py

@@ -15,7 +15,6 @@ def required_parset(cls, sample_data, modifier_data):
         return {
             'paramset_type': constrained_by_normal,
             'n_parameters': 1,
-            'modifier': cls.__name__,
             'is_constrained': cls.is_constrained,
             'is_shared': True,
             'inits': (0.0,),

src/pyhf/modifiers/shapefactor.py

@@ -14,7 +14,6 @@ def required_parset(cls, sample_data, modifier_data):
         return {
             'paramset_type': unconstrained,
             'n_parameters': len(sample_data),
-            'modifier': cls.__name__,
             'is_constrained': cls.is_constrained,
             'is_shared': True,
             'inits': (1.0,) * len(sample_data),

src/pyhf/modifiers/shapesys.py

@@ -22,7 +22,6 @@ def required_parset(cls, sample_data, modifier_data):
         return {
             'paramset_type': constrained_by_poisson,
             'n_parameters': n_parameters,
-            'modifier': cls.__name__,
             'is_constrained': cls.is_constrained,
             'is_shared': False,
             'inits': (1.0,) * n_parameters,

src/pyhf/modifiers/staterror.py

@@ -14,7 +14,6 @@ def required_parset(cls, sample_data, modifier_data):
         return {
             'paramset_type': constrained_by_normal,
             'n_parameters': len(sample_data),
-            'modifier': cls.__name__,
             'is_constrained': cls.is_constrained,
             'is_shared': True,
             'inits': (1.0,) * len(sample_data),