Skip to content

Commit 4ee6218

Browse files
Apply suggestions from Thibault from code review
Co-authored-by: Thibault Cordier <[email protected]>
1 parent 995e665 commit 4ee6218

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

examples/regression/1-quickstart/plot_cqr_symmetry_difference.py

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,13 @@
2626
gb_reg = GradientBoostingRegressor(loss="quantile", alpha=quantiles[1])
2727
gb_reg.fit(X, y)
2828

29-
# MAPIE Quantile Regressor with symmetry=True
30-
mapie_qr_sym = MapieQuantileRegressor(estimator=gb_reg, alpha=alpha)
31-
mapie_qr_sym.fit(X, y)
32-
y_pred_sym, y_pis_sym = mapie_qr_sym.predict(X, symmetry=True)
33-
34-
# MAPIE Quantile Regressor with symmetry=False
35-
mapie_qr_asym = MapieQuantileRegressor(estimator=gb_reg, alpha=alpha)
36-
mapie_qr_asym.fit(X, y)
37-
y_pred_asym, y_pis_asym = mapie_qr_asym.predict(X, symmetry=False)
29+
# MAPIE Quantile Regressor
30+
mapie_qr = MapieQuantileRegressor(estimator=gb_reg, alpha=alpha)
31+
mapie_qr.fit(X, y)
32+
y_pred_sym, y_pis_sym = mapie_qr.predict(X, symmetry=True)
33+
y_pred_asym, y_pis_asym = mapie_qr.predict(X, symmetry=False)
34+
y_qlow = mapie_qr.estimators_[0].predict(X)
35+
y_qup = mapie_qr.estimators_[1].predict(X)
3836

3937
# Calculate coverage scores
4038
coverage_score_sym = regression_coverage_score(
@@ -51,6 +49,8 @@
5149
y_pis_sym_sorted = y_pis_sym[order]
5250
y_pred_asym_sorted = y_pred_asym[order]
5351
y_pis_asym_sorted = y_pis_asym[order]
52+
y_qlow = y_qlow[order]
53+
y_qup = y_qup[order]
5454

5555
##############################################################################
5656
# We will plot the predictions and prediction intervals for both symmetric
@@ -64,7 +64,9 @@
6464
plt.xlabel("x")
6565
plt.ylabel("y")
6666
plt.scatter(X, y, alpha=0.3)
67-
plt.plot(X_sorted, y_pred_sym_sorted, color="C1")
67+
#plt.plot(X_sorted, y_pred_sym_sorted, color="C1")
68+
plt.plot(X_sorted, y_qlow, color="C1")
69+
plt.plot(X_sorted, y_qup, color="C1")
6870
plt.plot(X_sorted, y_pis_sym_sorted[:, 0], color="C1", ls="--")
6971
plt.plot(X_sorted, y_pis_sym_sorted[:, 1], color="C1", ls="--")
7072
plt.fill_between(
@@ -84,7 +86,9 @@
8486
plt.xlabel("x")
8587
plt.ylabel("y")
8688
plt.scatter(X, y, alpha=0.3)
87-
plt.plot(X_sorted, y_pred_asym_sorted, color="C2")
89+
#plt.plot(X_sorted, y_pred_asym_sorted, color="C2")
90+
plt.plot(X_sorted, y_qlow, color="C2")
91+
plt.plot(X_sorted, y_qup, color="C2")
8892
plt.plot(X_sorted, y_pis_asym_sorted[:, 0], color="C2", ls="--")
8993
plt.plot(X_sorted, y_pis_asym_sorted[:, 1], color="C2", ls="--")
9094
plt.fill_between(

0 commit comments

Comments
 (0)