Skip to content

Commit 50a76b2

Browse files
Merge pull request #516 from Valentin-Laurent/fix-contributing-set-up-with-pip
Fix the set-up with pip for new contributors
2 parents c23039a + 00e96b5 commit 50a76b2

File tree

6 files changed

+28
-7
lines changed

6 files changed

+28
-7
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,3 +85,6 @@ target/
8585

8686
# ZIP files
8787
*.zip
88+
89+
# Pyenv
90+
.python-version

CONTRIBUTING.rst

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,26 @@ Documenting your change
5050

5151
If you're adding a class or a function, then you'll need to add a docstring with a doctest. We follow the `numpy docstring convention <https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_numpy.html>`_, so please do too.
5252
Any estimator should follow the [scikit-learn API](https://scikit-learn.org/stable/developers/develop.html), so please follow these guidelines.
53-
In order to build the documentation locally, run :
53+
In order to build the documentation locally, you first need to install some dependencies :
54+
55+
Create a dedicated virtual environment via `conda`:
56+
57+
.. code:: sh
58+
59+
$ conda env create -f environment.doc.yml
60+
$ conda activate mapie-doc
61+
62+
Alternatively, using `pip`, create a different virtual environment than the one used for development, and install the dependencies:
63+
64+
.. code:: sh
65+
66+
$ pip install -r requirements.doc.txt
67+
$ pip install -e .
68+
69+
Finally, once dependencies are installed, you can build the documentation locally by running:
5470

5571
.. code:: sh
5672
57-
$ cd doc
5873
$ make clean-doc
5974
$ make doc
6075

HISTORY.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ History
44

55
0.9.x (2024-xx-xx)
66
------------------
7-
7+
* Fix (partially) the set-up with pip instead of conda for new contributors
88

99

1010
0.9.0 (2024-09-03)

requirements.ci.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,5 @@ mypy
44
pandas
55
pytest
66
pytest-cov
7+
scikit-learn
78
typed-ast

requirements.dev.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ flake8==4.0.1
33
ipykernel==6.9.0
44
jupyter==1.0.0
55
mypy==1.7.1
6-
numpy==1.22.3
76
numpydoc==1.1.0
7+
numpy==1.22.3
88
pandas==1.3.5
99
pytest==6.2.5
1010
pytest-cov==3.0.0
@@ -13,4 +13,4 @@ sphinx==4.3.2
1313
sphinx-gallery==0.10.1
1414
sphinx_rtd_theme==1.0.0
1515
twine==3.7.1
16-
wheel==0.38.1
16+
wheel==0.37.0

requirements.doc.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1-
lightgbm==3.2.1
1+
lightgbm==4.4.0
22
matplotlib==3.5.1
3+
numpy==1.22.3
34
numpydoc==1.1.0
45
pandas==1.3.5
5-
sphinx==4.3.2
6+
scikit-learn
7+
sphinx==5.3.0
68
sphinx-gallery==0.10.1
79
sphinx_rtd_theme==1.0.0
810
typing_extensions==4.0.1

0 commit comments

Comments
 (0)