TST: test that estimator don't fail if given many alphas

vincentblot28 · vincentblot28 · commit 7672b2e61dda · 2024-09-02T18:22:25.000+02:00
diff --git a/mapie/tests/test_mondrian.py b/mapie/tests/test_mondrian.py
@@ -177,7 +177,8 @@
 
 
 @pytest.mark.parametrize("mapie_estimator_name", VALID_MAPIE_ESTIMATORS_NAMES)
-def test_valid_estimators_dont_fail(mapie_estimator_name):
+@pytest.mark.parametrize("alpha", [.2, [.2, .4]])
+def test_valid_estimators_dont_fail(mapie_estimator_name, alpha):
     """Test that valid estimators don't fail"""
     task_dict = VALID_MAPIE_ESTIMATORS[mapie_estimator_name]
     mapie_estimator = task_dict["estimator"]
@@ -196,7 +197,7 @@ def test_valid_estimators_dont_fail(mapie_estimator_name):
         )
     )
     mondrian_cp.fit(x, y, partition=partition)
-    mondrian_cp.predict(x, partition=partition, alpha=.2)
+    mondrian_cp.predict(x, partition=partition, alpha=alpha)
 
 
 @pytest.mark.parametrize(

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,8 @@`
`177`	`177`
`178`	`178`
`179`	`179`	`@pytest.mark.parametrize("mapie_estimator_name", VALID_MAPIE_ESTIMATORS_NAMES)`
`180`		`-def test_valid_estimators_dont_fail(mapie_estimator_name):`
	`180`	`+@pytest.mark.parametrize("alpha", [.2, [.2, .4]])`
	`181`	`+def test_valid_estimators_dont_fail(mapie_estimator_name, alpha):`
`181`	`182`	`"""Test that valid estimators don't fail"""`
`182`	`183`	`task_dict = VALID_MAPIE_ESTIMATORS[mapie_estimator_name]`
`183`	`184`	`mapie_estimator = task_dict["estimator"]`
`@@ -196,7 +197,7 @@ def test_valid_estimators_dont_fail(mapie_estimator_name):`
`196`	`197`	`)`
`197`	`198`	`)`
`198`	`199`	`mondrian_cp.fit(x, y, partition=partition)`
`199`		`- mondrian_cp.predict(x, partition=partition, alpha=.2)`
	`200`	`+ mondrian_cp.predict(x, partition=partition, alpha=alpha)`
`200`	`201`
`201`	`202`
`202`	`203`	`@pytest.mark.parametrize(`