Skip to content

Commit 8583e6b

Browse files
Merge pull request #485 from scikit-learn-contrib/473-replace-assert-nparray_equal-by-nptestingassert_array_equal-in-all-mapie-unit-tests
473 replace assert nparray equal by nptestingassert array equal in all mapie unit tests
2 parents 0293f2d + 17f56cd commit 8583e6b

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

HISTORY.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ History
55
0.8.x (2024-xx-xx)
66
------------------
77

8+
* Replace `assert np.array_equal` by `np.testing.assert_array_equal` in Mapie unit tests
89
* Replace `github.com/simai-ml/MAPIE` by `github.com/scikit-learn-contrib/MAPIE`in all Mapie files
910
* Extend `ConformityScore` to support regression (with `BaseRegressionScore`) and to support classification (with `BaseClassificationScore`)
1011
* Extend `EnsembleEstimator` to support regression (with `EnsembleRegressor`) and to support classification (with `EnsembleClassifier`)

mapie/tests/test_classification.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1380,8 +1380,10 @@ def test_results_with_groups() -> None:
13801380
# (array([1, 2, 4, 5]), array([0, 3]))]
13811381
conformity_scores_0 = np.array([[1.], [0.], [0.], [1.], [1.], [1.]])
13821382
conformity_scores_1 = np.array([[1.], [1.], [1.], [1.], [1.], [1.]])
1383-
assert np.array_equal(mapie0.conformity_scores_, conformity_scores_0)
1384-
assert np.array_equal(mapie1.conformity_scores_, conformity_scores_1)
1383+
np.testing.assert_array_equal(mapie0.conformity_scores_,
1384+
conformity_scores_0)
1385+
np.testing.assert_array_equal(mapie1.conformity_scores_,
1386+
conformity_scores_1)
13851387

13861388

13871389
@pytest.mark.parametrize(

mapie/tests/test_regression.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -563,8 +563,10 @@ def test_results_with_groups() -> None:
563563
y_pred_1 = [15, 10, 5, 15, 10, 5]
564564
conformity_scores_0 = np.abs(y - y_pred_0)
565565
conformity_scores_1 = np.abs(y - y_pred_1)
566-
assert np.array_equal(mapie0.conformity_scores_, conformity_scores_0)
567-
assert np.array_equal(mapie1.conformity_scores_, conformity_scores_1)
566+
np.testing.assert_array_equal(mapie0.conformity_scores_,
567+
conformity_scores_0)
568+
np.testing.assert_array_equal(mapie1.conformity_scores_,
569+
conformity_scores_1)
568570

569571

570572
@pytest.mark.parametrize("strategy", [*STRATEGIES])

0 commit comments

Comments
 (0)