Skip to content

Commit dc40a7e

Browse files
author
Thibault Cordier
committed
UPD: change p-values (more conservative)
1 parent 7004159 commit dc40a7e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

mapie/tests/test_regression.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ def test_predict_output_shape(
260260

261261

262262
@pytest.mark.parametrize("delta", [0.5, 0.6, 0.7, 0.8])
263-
@pytest.mark.parametrize("n_calib", [10, 15, 20, 25, 50, 100, 1000])
263+
@pytest.mark.parametrize("n_calib", [10, 15, 20, 25, 50, 100, 1000])
264264
def test_coverage_validity(delta: float, n_calib: int) -> None:
265265
"""
266266
Test that the prefit method provides valid coverage
@@ -292,7 +292,7 @@ def test_coverage_validity(delta: float, n_calib: int) -> None:
292292
from scipy.stats import ttest_1samp
293293
_, pval = ttest_1samp(coverage_list, popmean=delta, alternative='less')
294294

295-
np.testing.assert_array_less(0.05, pval)
295+
np.testing.assert_array_less(0.01, pval)
296296

297297

298298
def test_same_results_prefit_split() -> None:

0 commit comments

Comments
 (0)