added more tests

Author: PaulWestenthanner

category_encoders/ordinal.py

@@ -241,7 +241,7 @@ def ordinal_encoding(X_in, mapping=None, cols=None, handle_unknown='value', hand
 
         return X, mapping_out
 
-    def _validate_supplied_mapping(self, supplied_mapping: List[Dict[str, Union[Dict, pd.Series]]]) -> List[Dict[str, pd.Series]]:
+    def _validate_supplied_mapping(self, supplied_mapping: List[Dict[str, Union[str, Dict, pd.Series]]]) -> List[Dict[str, Union[str, pd.Series]]]:
         """
         validate the supplied mapping and convert the actual mapping per column to a pandas series.
         :param supplied_mapping: mapping as list of dicts. They actual mapping can be either a dict or pd.Series

tests/test_ordinal.py

@@ -316,7 +316,27 @@ def test_inverse_with_mapping(self):
                     return_df=True,
                 )
                 df[categoricals] = enc.fit_transform(df[categoricals])
-                print("ord mapping after fit")
-                print(enc.mapping)
                 recovered = enc.inverse_transform(df[categoricals])
                 pd.testing.assert_frame_equal(X[categoricals], recovered)
+
+    def test_validate_mapping(self):
+        custom_mapping = [
+            {
+                "col": "col1",
+                "mapping": {np.NaN: 0, "a": 1, "b": 2},
+            },  # The mapping from the documentation
+            {"col": "col2", "mapping": {np.NaN: -3, "x": 11, "y": 2}},
+        ]
+        expected_valid_mapping = [
+            {
+                "col": "col1",
+                "mapping": pd.Series({np.NaN: 0, "a": 1, "b": 2}),
+            },  # The mapping from the documentation
+            {"col": "col2", "mapping": pd.Series({np.NaN: -3, "x": 11, "y": 2})},
+        ]
+        enc = encoders.OrdinalEncoder()
+        actual_valid_mapping = enc._validate_supplied_mapping(custom_mapping)
+        self.assertEqual(len(actual_valid_mapping), len(expected_valid_mapping))
+        for idx in range(len(actual_valid_mapping)):
+            self.assertEqual(actual_valid_mapping[idx]["col"], expected_valid_mapping[idx]["col"])
+            pd.testing.assert_series_equal(actual_valid_mapping[idx]["mapping"], expected_valid_mapping[idx]["mapping"])