Skip to content

Commit d737e17

Browse files
Merge pull request #334 from jona-sassenhagen/jona/fix_pandas_future_warning_for_dropping_invariants
Fix pandas future warning for dropping invariants
2 parents 531a271 + 0f839e0 commit d737e17

17 files changed

+18
-36
lines changed

category_encoders/backward_difference.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,8 +214,7 @@ def transform(self, X, override_return_df=False):
214214
X = self.backward_difference_coding(X, mapping=self.mapping)
215215

216216
if self.drop_invariant:
217-
for col in self.drop_cols:
218-
X.drop(col, 1, inplace=True)
217+
X = X.drop(columns=self.drop_cols)
219218

220219
if self.return_df or override_return_df:
221220
return X

category_encoders/basen.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,7 @@ def transform(self, X, override_return_df=False):
253253
X_out = self.basen_encode(X_out, cols=self.cols)
254254

255255
if self.drop_invariant:
256-
for col in self.drop_cols:
257-
X_out.drop(col, 1, inplace=True)
256+
X_out = X_out.drop(columns=self.drop_cols)
258257

259258
# impute missing values only in the generated columns
260259
# generated_cols = util.get_generated_cols(X, X_out, self.cols)

category_encoders/cat_boost.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,7 @@ def transform(self, X, y=None, override_return_df=False):
208208
)
209209

210210
if self.drop_invariant:
211-
for col in self.drop_cols:
212-
X.drop(col, 1, inplace=True)
211+
X = X.drop(columns=self.drop_cols)
213212

214213
if self.return_df or override_return_df:
215214
return X

category_encoders/count.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,7 @@ def transform(self, X, y=None, override_return_df=False):
229229
X, _ = self._transform_count_encode(X, y)
230230

231231
if self.drop_invariant:
232-
for col in self.drop_cols:
233-
X.drop(col, 1, inplace=True)
232+
X = X.drop(columns=self.drop_cols)
234233

235234
if self.return_df or override_return_df:
236235
return X

category_encoders/glmm.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,8 +226,7 @@ def transform(self, X, y=None, override_return_df=False):
226226
# Postprocessing
227227
# Note: We should not even convert these columns.
228228
if self.drop_invariant:
229-
for col in self.drop_cols:
230-
X.drop(col, 1, inplace=True)
229+
X = X.drop(columns=self.drop_cols)
231230

232231
if self.return_df or override_return_df:
233232
return X

category_encoders/hashing.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,7 @@ def require_data(self, data_lock, new_start, done_index, hashing_parts, cols, pr
202202
# Always get df and check it after merge all data parts
203203
data_part = self.hashing_trick(X_in=data_part, hashing_method=self.hash_method, N=self.n_components, cols=self.cols)
204204
if self.drop_invariant:
205-
for col in self.drop_cols:
206-
data_part.drop(col, 1, inplace=True)
205+
data_part = data_part.drop(columns=self.drop_cols)
207206
part_index = int(math.ceil(end_index / self.max_sample))
208207
hashing_parts.put({part_index: data_part})
209208
if self.verbose == 5:
@@ -308,8 +307,7 @@ def _transform(self, X, override_return_df=False):
308307
X = self.hashing_trick(X, hashing_method=self.hash_method, N=self.n_components, cols=self.cols)
309308

310309
if self.drop_invariant:
311-
for col in self.drop_cols:
312-
X.drop(col, 1, inplace=True)
310+
X = X.drop(columns=self.drop_cols)
313311

314312
if self.return_df or override_return_df:
315313
return X

category_encoders/helmert.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,8 +211,7 @@ def transform(self, X, override_return_df=False):
211211
X = self.helmert_coding(X, mapping=self.mapping)
212212

213213
if self.drop_invariant:
214-
for col in self.drop_cols:
215-
X.drop(col, 1, inplace=True)
214+
X = X.drop(columns=self.drop_cols)
216215

217216
if self.return_df or override_return_df:
218217
return X

category_encoders/james_stein.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,8 +289,7 @@ def transform(self, X, y=None, override_return_df=False):
289289
# Postprocessing
290290
# Note: We should not even convert these columns.
291291
if self.drop_invariant:
292-
for col in self.drop_cols:
293-
X.drop(col, 1, inplace=True)
292+
X = X.drop(columns=self.drop_cols)
294293

295294
if self.return_df or override_return_df:
296295
return X

category_encoders/leave_one_out.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,7 @@ def transform(self, X, y=None, override_return_df=False):
195195
)
196196

197197
if self.drop_invariant:
198-
for col in self.drop_cols:
199-
X.drop(col, 1, inplace=True)
198+
X = X.drop(columns=self.drop_cols)
200199

201200
if self.return_df or override_return_df:
202201
return X

category_encoders/m_estimate.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,7 @@ def transform(self, X, y=None, override_return_df=False):
221221
# Postprocessing
222222
# Note: We should not even convert these columns.
223223
if self.drop_invariant:
224-
for col in self.drop_cols:
225-
X.drop(col, 1, inplace=True)
224+
X = X.drop(columns=self.drop_cols)
226225

227226
if self.return_df or override_return_df:
228227
return X

0 commit comments

Comments
 (0)