Merge pull request #14 from MatthewSZhang/dev

MatthewSZhang · web-flow · commit 589fa3e188a5 · 2024-10-18T14:51:19.000+08:00
MNT Cython remove unnecessary memset of mask
diff --git a/fastcan/_cancorr_fast.pyx b/fastcan/_cancorr_fast.pyx
@@ -155,7 +155,6 @@ cpdef int _forward_search(
         int index = -1
 
     memset(&r2[0], 0, n_features * sizeof(floating))
-    memset(&mask[0], False, n_features * sizeof(bint))
 
     for i in range(t):
         if i == 0:
diff --git a/fastcan/_utils.py b/fastcan/_utils.py
@@ -97,7 +97,7 @@ def ols(X, y, t=1):
     w = X / np.linalg.norm(X, axis=0)
     v = y / np.linalg.norm(y)
     mask = np.zeros(n_features, dtype=bool)
-    r2 = np.zeros(n_features)
+    r2 = np.zeros(n_features, dtype=float)
     indices = np.zeros(t, dtype=int)
     scores = np.zeros(t, dtype=float)
 
diff --git a/pixi.lock b/pixi.lock
