Skip to content

MNT padding nan in time shift #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

MNT padding nan in time shift #102

merged 2 commits into from
May 30, 2025

Conversation

@MatthewSZhang
Copy link
Collaborator

@MatthewSZhang MatthewSZhang commented May 30, 2025

Checklist

@MatthewSZhang MatthewSZhang self-assigned this May 30, 2025
@MatthewSZhang MatthewSZhang added the bug Something isn't working label May 30, 2025
This was linked to issues May 30, 2025
Time shift should support padding nan #100
Closed
Number of nan to split time series should at least equal to the maximum delay of NARX #101
Closed
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2025 •
edited by codecov bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (84b2f83) to head (8bdc65b).
⚠️ Report is 59 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          603       612    +9     
=========================================
+ Hits           603       612    +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MatthewSZhang MatthewSZhang merged commit 4a7c4bb into scikit-learn-contrib:main May 30, 2025
5 checks passed
@MatthewSZhang MatthewSZhang deleted the time-shift branch May 30, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@MatthewSZhang MatthewSZhang

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Number of nan to split time series should at least equal to the maximum delay of NARX Time shift should support padding nan

2 participants

@MatthewSZhang @codecov-commenter