Compatibility with scikit-learn > 1.5?

[flo-ri-an]

The current version requirement for scikit-learn forces us to use a version that has known vulnerabilities (GHSA-jw8x-6495-233v).

Is there any specific reason for the version constraint? If not, I'd happily open a PR to upgrade.

[mirand863]

Hi @flo-ri-an

Thank you for opening this issue. I was not aware that this would bring vulnerabilities. It must be fixed as soon as possible.

The reason why there is a constraint is because hiclass is currently incompatible with the latest version of sklearn. I opened PR #142 to update sklearn. I fixed many bugs/tests to work with the latest version, but there are still some issues with the explainer and multi-label classes that I was not able to fix. Can you please give it a try?

[greenlymicael]

Hi @mirand863 ,

We're also impacted by the version restriction imposed by the library.
I started doing some tests, and so far got this warning:

FutureWarning: BaseEstimator._validate_data is deprecated in 1.6 and will be removed in 1.7. Use sklearn.utils.validation.validate_data instead. This function becomes public and is part of the scikit-learn developer API.

Which I assume it's because of the usage of this function in the HierarchicalClassifier and MultiLabelHierarchicalClassifier

[mirand863]

Hi @greenlymicael,

I was just updating the PR to fix this. I am removing the explainer, bert and the multi-label classifiers for now as they are causing this compatibility issue and I am not sure how to make them compatible at the moment. I hope you and @flo-ri-an do not need these features.

I will also update the validate_data function.

[greenlymicael]

For me not at the moment no

[flo-ri-an]

thanks for picking this up again, I did not get the chance to look into it yet. For me this limitation is also fine, we use neither of the mentioned features

[greenlymicael]

Hey @mirand863 ,

I'm still getting this FutureWarning:

FutureWarning: `BaseEstimator._validate_data` is deprecated in 1.6 and will be removed in 1.7. Use `sklearn.utils.validation.validate_data` instead. This function becomes public and is part of the scikit-learn developer API.

[mirand863]

Hi @greenlymicael,

Sorry, forgot to update it before. It should be fixed now on version 5.0.4.