Skip to content

Commit 662aa64

Browse files
committed
Correct doc and Readme.rst and Fix typing errors
1 parent 290939e commit 662aa64

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

docs/analysis.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ The MCAR missing-data mechanism means that there is independence between the pre
4545
a. Little's Test
4646
^^^^^^^^^^^^^^^^
4747

48-
The best-known MCAR test is the :ref:`Little [2]<Little-article>` test, and it has been implemented in :class:`LittleTest`. Keep in mind that the Little's test is designed to test the homogeneity of means across the missing patterns and won't be efficient to detect the heterogeneity of covariance accross missing patterns.
48+
The best-known MCAR test is the :ref:`Little [1]<Little-article>` test, and it has been implemented in :class:`LittleTest`. Keep in mind that the Little's test is designed to test the homogeneity of means across the missing patterns and won't be efficient to detect the heterogeneity of covariance accross missing patterns.
4949

5050
b. PKLM Test
5151
^^^^^^^^^^^^

docs/images/schema_qolmat.png

5.35 KB
Loading

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ twine = "3.7.1"
5353
wheel = "0.37.1"
5454
category-encoders = "^2.6.3"
5555
ipykernel = "^6.29.5"
56-
torch = "^2.4.0"
56+
torch = "*"
5757

5858
[tool.poetry.dev-dependencies]
5959
matplotlib = "3.6.2"

qolmat/analysis/holes_characterization.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ def _draw_features_and_target_indexes(
334334
@staticmethod
335335
def _check_draw(
336336
X: np.ndarray, features_idx: List[int], target_idx: int
337-
) -> np.bool_:
337+
) -> bool:
338338
"""Check if the drawn features and target are valid.
339339
340340
Here we check
@@ -365,7 +365,7 @@ def _check_draw(
365365

366366
def _generate_label_feature_combinations(
367367
self, X: np.ndarray
368-
) -> List[Tuple[int, List[int]]]:
368+
) -> List[Tuple[List[int], int]]:
369369
"""Generate all valid combinations of features and labels.
370370
371371
Parameters
@@ -687,7 +687,7 @@ def _compute_partial_p_value(
687687
688688
"""
689689
U_k = B[k, :] @ U
690-
p_v_k = 1
690+
p_v_k = 1.
691691

692692
for u_sigma_k in (B[k, :] @ U_sigma).tolist():
693693
if u_sigma_k >= U_k:
@@ -745,7 +745,7 @@ def test(
745745
U = U / self.nb_projections
746746
list_U_sigma = [x / self.nb_permutation for x in list_U_sigma]
747747

748-
p_value = 1
748+
p_value = 1.
749749
for u_sigma in list_U_sigma:
750750
if u_sigma >= U:
751751
p_value += 1

0 commit comments

Comments
 (0)