plot tests avoiding MockerFixture

Author: Julien Roussel

tests/utils/test_plot.py

@@ -1,11 +1,11 @@
 from typing import Any, List, Tuple
+from unittest.mock import patch
 
 import matplotlib.pyplot as plt
 import numpy as np
 import pandas as pd
 import pytest
 import scipy.sparse
-from pytest_mock.plugin import MockerFixture
 
 from qolmat.utils import plot
 
@@ -38,64 +38,63 @@
 
 
 @pytest.mark.parametrize("list_matrices", [list_matrices])
+@patch("matplotlib.pyplot.show")
+@patch("matplotlib.pyplot.savefig")
 def test_utils_plot_plot_matrices(
-    list_matrices: List[np.ndarray], mocker: MockerFixture
+    mock_savefig, mock_show, list_matrices: List[np.ndarray]
 ) -> None:
-    mocker.patch("matplotlib.pyplot.savefig")
-    mocker.patch("matplotlib.pyplot.show")
     plot.plot_matrices(list_matrices=list_matrices, title="title")
     assert len(plt.gcf().get_axes()) > 0
-    assert plt.savefig.call_count == 1
+    assert mock_savefig.call_count == 1
     plt.close("all")
 
 
 @pytest.mark.parametrize("list_signals", [list_signals])
+@patch("matplotlib.pyplot.show")
+@patch("matplotlib.pyplot.savefig")
 def test_utils_plot_plot_signal(
-    list_signals: List[List[Any]], mocker: MockerFixture
+    mock_savefig, mock_show, list_signals: List[List[Any]]
 ) -> None:
-    mocker.patch("matplotlib.pyplot.savefig")
-    mocker.patch("matplotlib.pyplot.show")
     plot.plot_signal(list_signals=list_signals, ylabel="ylabel", title="title")
     assert len(plt.gcf().get_axes()) > 0
-    assert plt.savefig.call_count == 1
+    assert mock_savefig.call_count == 1
     plt.close("all")
 
 
 @pytest.mark.parametrize(
     "M, A, E, index_array, dims", [(M, A, E, [0, 1, 2], (10, 10))]
 )
+@patch("matplotlib.pyplot.show")
+@patch("matplotlib.pyplot.savefig")
 def test__utils_plot_plot_images(
+    mock_savefig,
+    mock_show,
     M: np.ndarray,
     A: np.ndarray,
     E: np.ndarray,
     index_array: List[int],
     dims: Tuple[int, int],
-    mocker: MockerFixture,
 ):
-    mocker.patch("matplotlib.pyplot.savefig")
-    mocker.patch("matplotlib.pyplot.show")
     plot.plot_images(M, A, E, index_array, dims, filename="filename")
     assert len(plt.gcf().get_axes()) > 0
-    assert plt.savefig.call_count == 1
+    assert mock_savefig.call_count == 1
     plt.close("all")
 
 
 @pytest.mark.parametrize("X", [X])
-def test_utils_plot_make_ellipses_from_data(
-    X: np.ndarray, mocker: MockerFixture
-):
-    mocker.patch("matplotlib.pyplot.show")
+@patch("matplotlib.pyplot.show")
+def test_utils_plot_make_ellipses_from_data(mock_show, X: np.ndarray):
     ax = plt.gca()
     plot.make_ellipses_from_data(X[1], X[2], ax, color="blue")
     assert len(plt.gcf().get_axes()) > 0
     plt.close("all")
 
 
 @pytest.mark.parametrize("df1,df2", [(df1, df2)])
+@patch("matplotlib.pyplot.show")
 def test_utils_plot_compare_covariances(
-    df1: pd.DataFrame, df2: pd.DataFrame, mocker: MockerFixture
+    mock_show, df1: pd.DataFrame, df2: pd.DataFrame
 ):
-    mocker.patch("matplotlib.pyplot.show")
     ax = plt.gca()
     plot.compare_covariances(df1, df2, "x", "y", ax)
     assert len(plt.gcf().get_axes()) > 0
@@ -104,18 +103,16 @@ def test_utils_plot_compare_covariances(
 
 @pytest.mark.parametrize("df", [df])
 @pytest.mark.parametrize("orientation", ["horizontal", "vertical"])
-def test_utils_plot_multibar(
-    df: pd.DataFrame, orientation: str, mocker: MockerFixture
-):
-    mocker.patch("matplotlib.pyplot.show")
+@patch("matplotlib.pyplot.show")
+def test_utils_plot_multibar(mock_show, df: pd.DataFrame, orientation: str):
     plot.multibar(df, orientation=orientation)
     assert len(plt.gcf().get_axes()) > 0
     plt.close("all")
 
 
 @pytest.mark.parametrize("df", [df])
-def test_utils_plot_plot_imputations(df: pd.DataFrame, mocker: MockerFixture):
-    mocker.patch("matplotlib.pyplot.show")
+@patch("matplotlib.pyplot.show")
+def test_utils_plot_plot_imputations(mock_show, df: pd.DataFrame):
     plot.plot_imputations(df, dict_df_imputed)
     assert len(plt.gcf().get_axes()) > 0
     plt.close("all")