Skip to content

Commit 02a9edf

Browse files
committed
Remembering to add TODOs after last week conversation
1 parent aef9d91 commit 02a9edf

File tree

4 files changed

+7
-1
lines changed

4 files changed

+7
-1
lines changed

src/skmatter/decomposition/_kernel_pcovc.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -488,3 +488,5 @@ def decision_function(self, X=None, T=None):
488488
return [
489489
est_.decision_function(T) for est_ in self.classifier_.estimators_
490490
]
491+
492+
#TODO: add MultiOutputClassifier's score function for KPCovC to allow for multiclass-multioutput case

src/skmatter/decomposition/_pcovc.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -513,3 +513,5 @@ def transform(self, X=None):
513513
and n_features is the number of features.
514514
"""
515515
return super().transform(X)
516+
517+
#TODO: add MultiOutputClassifier's score function for PCovC to allow for multiclass-multioutput case

tests/test_kernel_pcovc.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,8 @@ def test_decision_function_multioutput(self):
580580
T = kpcovc.transform(self.X)
581581
_ = kpcovc.decision_function(T=T)
582582

583+
#TODO: Add tests for addition of score function to pcovc.py
584+
583585

584586
if __name__ == "__main__":
585587
unittest.main(verbosity=2)

tests/test_pcovc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -656,6 +656,6 @@ def test_decision_function_multioutput(self):
656656
T = pcovc.transform(self.X)
657657
_ = pcovc.decision_function(T=T)
658658

659-
659+
#TODO: Add tests for addition of score function to pcovc.py
660660
if __name__ == "__main__":
661661
unittest.main(verbosity=2)

0 commit comments

Comments
 (0)