Skip to content

Commit 04cfab0

Browse files
author
Christian Jorgensen
committed
Adding tests
1 parent cd2d27b commit 04cfab0

File tree

2 files changed

+20
-0
lines changed

2 files changed

+20
-0
lines changed

tests/test_kernel_pcovc.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,15 @@ def test_precomputed_classification(self):
327327
self.assertTrue(np.linalg.norm(t3 - t2) < self.error_tol)
328328
self.assertTrue(np.linalg.norm(t3 - t1) < self.error_tol)
329329

330+
def test_scale_z_parameter(self):
331+
"""Check that changing scale_z changes the eigendecomposition."""
332+
kpcovc_scaled = self.model(scale_z=True)
333+
kpcovc_scaled.fit(self.X, self.Y)
334+
335+
kpcovc_unscaled = self.model(scale_z=False)
336+
kpcovc_unscaled.fit(self.X, self.Y)
337+
assert not np.allclose(kpcovc_scaled.pkt_, kpcovc_unscaled.pkt_)
338+
330339

331340
class KernelTests(KernelPCovCBaseTest):
332341
def test_kernel_types(self):

tests/test_pcovc.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -578,6 +578,17 @@ def test_incompatible_coef_shape(self):
578578
% (len(pcovc_multi.classes_), self.X.shape[1], cl_binary.coef_.shape),
579579
)
580580

581+
def test_scale_z_parameter(self):
582+
"""Check that changing scale_z changes the eigendecomposition."""
583+
pcovc_scaled = self.model(scale_z=True)
584+
pcovc_scaled.fit(self.X, self.Y)
585+
586+
pcovc_unscaled = self.model(scale_z=False)
587+
pcovc_unscaled.fit(self.X, self.Y)
588+
assert not np.allclose(
589+
pcovc_scaled.singular_values_, pcovc_unscaled.singular_values_
590+
)
591+
581592

582593
if __name__ == "__main__":
583594
unittest.main(verbosity=2)

0 commit comments

Comments
 (0)