Skip to content

Commit 656a5b7

Browse files
agoscinskiPicoCentauri
authored andcommitted
add random state to svd in _compute_pi function to make examples deterministic
1 parent 2bd2d3d commit 656a5b7

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/skmatter/_selection.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -649,14 +649,15 @@ def _compute_pi(self, X, y=None):
649649
:math:`\\pi` importance for the given samples or features
650650
"""
651651

652+
svd_kwargs = dict(k=self.k, random_state=self.random_state)
652653
if self._axis == 0:
653-
U, _, _ = scipy.sparse.linalg.svds(X, k=self.k, return_singular_vectors="u")
654+
svd_kwargs["return_singular_vectors"] = "u"
655+
U, _, _ = scipy.sparse.linalg.svds(X, **svd_kwargs)
654656
U = np.real(U)
655657
new_pi = (U[:, : self.k] ** 2.0).sum(axis=1)
656658
else:
657-
_, _, Vt = scipy.sparse.linalg.svds(
658-
X, k=self.k, return_singular_vectors="vh"
659-
)
659+
svd_kwargs["return_singular_vectors"] = "vh"
660+
_, _, Vt = scipy.sparse.linalg.svds(X, **svd_kwargs)
660661
new_pi = (np.real(Vt) ** 2.0).sum(axis=0)
661662

662663
return new_pi

src/skmatter/sample_selection/_base.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,6 @@ class CUR(_CUR):
342342
... [-0.03, -0.53, 0.08],
343343
... ]
344344
... )
345-
>>> np.random.seed(0) # there is a source of randomness in it
346345
>>> selector.fit(X)
347346
CUR(n_to_select=2)
348347
>>> np.round(selector.pi_, 2) # importance scole

0 commit comments

Comments
 (0)