Skip to content

Commit 992ce44

Browse files
author
Christian Jorgensen
committed
DCH inherits from base estimator
1 parent 0306911 commit 992ce44

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ classifiers = [
3838
"Topic :: Scientific/Engineering",
3939
]
4040
dependencies = [
41-
"scikit-learn >= 1.6, < 1.7",
41+
"scikit-learn >= 1.7",
4242
"scipy >= 1.15", # explicit to adhere to scikit-learn dependencies
4343
]
4444
dynamic = ["version"]

src/skmatter/sample_selection/_base.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
from scipy.interpolate._interpnd import _ndim_coords_from_arrays
88
from scipy.spatial import ConvexHull
99
from sklearn.utils.validation import check_array, check_is_fitted, check_X_y
10+
from sklearn.base import BaseEstimator
1011

1112
from .._selection import _CUR, _FPS, _PCovCUR, _PCovFPS
1213

@@ -479,7 +480,7 @@ def _directional_distance(equations, points):
479480
return -orthogonal_distances / equations[:, :1].T
480481

481482

482-
class DirectionalConvexHull:
483+
class DirectionalConvexHull(BaseEstimator):
483484
"""
484485
Performs Sample Selection by constructing a Directional Convex Hull and determining
485486
the distance to the hull as outlined in the reference [dch]_.

0 commit comments

Comments
 (0)