Ensure FPS/CUR selected idxs are unique in the case of zero-score #224
Conversation
|
Are you still looking for feedback on this? Good measure to tag one of us for input. |
|
Hey! This isn't something I'm actively working on at the moment, but I'll be sure to ping you for feedback when I / we get back round to it :) |
|
I had the problem that CUR sample selection would give duplicate selected indices, for example X.selected_idx_ == I cannot comment on the validity of the code, but this branch solves this problem to instead give unique predictions like this, X.selected_idx_ == |
|
Moved over to #265 |
4 participants
Attempting to fix #206
Hello!
I have encountered the issue raised by Alex in the above issue, whilst working with the equisolve wrapper for TensorMap-based sample/feature selection (i.e. in https://github.com/lab-cosmo/equisolve/blob/main/src/equisolve/numpy/sample_selection.py and co).
I have adapted Alex's example into a few unit tests for both FPS and CUR sample/feature selection, and attempted to fix it. However, there is something I'm not understanding. While the FPS tests now pass, there are a couple of (different) CUR ones that do not.
With this PR I was hoping to get some feedback/help from the skmatter dev team on this. Thanks! :)
Contributor (creator of PR) checklist
Documentation updated (for new features)?For Reviewer
📚 Documentation preview 📚: https://scikit-matter--224.org.readthedocs.build/en/224/