Skip to content

New PR for adding KPCovC code #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
May 14, 2025
Merged

New PR for adding KPCovC code #247

merged 44 commits into from
May 14, 2025

Conversation

@rvasav26
Copy link
Collaborator

@rvasav26 rvasav26 commented May 14, 2025 •
edited
Loading

Adding KPCovC code, examples, and testing suite. Adding a KPCov base class that both KPCovR and KPCovC inherit from. This code also contains the PCov, PCovR, and PCovC code from the beginning of the PCovC PR. Will rebase once the PCovC PR is finalized.

Contributor (creator of PR) checklist

  • Tests updated (for new features and bugfixes)?
  • Documentation updated (for new features)?
  • Issue referenced (for PRs that solve an issue)?

For Reviewer

  • CHANGELOG updated if important change?

rvasav26 and others added 30 commits April 10, 2025 12:27
@rvasav26
Adding PCovC code
93be99a
@rvasav26
Merge remote-tracking branch 'upstream/main'
cb9dba8
@rvasav26
Changing check_lr_fit to check_cl_fit and updating respective tests.
ead6516
@rvasav26
Adding KPCovC code, as well as KPCovC tests.
8d00fe6
@rvasav26
Adding PCovC code
427dc8d
@rvasav26
Changing check_lr_fit to check_cl_fit and updating respective tests.
4697039
@rvasav26
Adding KPCovC code, as well as KPCovC tests.
e51ddd7
@rvasav26
Fixing error in pull request
3191c26
@rvasav26
Working on KPCovC
bd21668
@rvasav26
Moving files around
44169bc
@rvasav26
Investigating PCovCSPaceTest errors
96ae408
@rvasav26
Adding _BasePCov class and modifying PCovR and PCovC to implement bas…
1b99d0f 
…e class
@rvasav26
Working on _BasePCov class and changing docstrings for PCovC
ab45da6
@rvasav26
Fixing errors with PCovC self.classifier_
ae1dc0d
@rvasav26
Cleaning up _BasePCov along with new PCovR and PCovC subclasses
1bb0d75
@rvasav26
Working on KPCovC SVC compatibility
5d5dd32
@rvasav26
Working on KPCovC, investigating minor errors
9d784c6
@rvasav26
Fixing decision_function shape for PCovC, writing corresponding Z test
86968dc
@rvasav26
Changing check_cl_fit to check for classifier coefficient mismatches
2e83a57
@rvasav26
Cleaning up documentation, refactoring KPCovC
f1bc971
@rvasav26
Tweaking docstrings for PCovC
206abea
@rvasav26
Renaming files, reworking check for compatible classifiers/regressors
a120baf
@cajchristian @rvasav26
Setting up __init__.py
a42d669
@rvasav26
Minor fix to PCovR after skmatter update with sklearn 1.6
153b815
@cajchristian
Fixing imports
bbd90d0
@rvasav26
Minor sklearn update changes to PCovC, modifying example graphs
6318783
@rvasav26
Cleaning up files, working on fixing KPCovC errors
a030906
@rvasav26
Using validate_data in PCovC/KPCovC for scikit-learn compatibility
0c8fa48
@rvasav26
Fixing formatting for example notebooks
4e0404a
@rvasav26
Modifying decision_function for PCovC/KPCovC
efe6488
@rvasav26 rvasav26 marked this pull request as ready for review May 14, 2025 02:01
@rvasav26 rvasav26 merged commit d80ba52 into scikit-learn-contrib:adding-kpcovc May 14, 2025
2 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rvasav26 @cajchristian