Skip to content

Commit 3be2424

Browse files
committed
pass test files
1 parent 680e01b commit 3be2424

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

skglm/tests/test_estimators.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,8 @@ def test_CoxEstimator(use_efron, use_float_32):
207207
datafit = Cox(use_efron)
208208
penalty = L1(alpha)
209209

210+
# XXX: intialize is needed here although it is done in ProxNewton
211+
# it is used to evaluate the objective
210212
datafit.initialize(X, y)
211213

212214
w, *_ = ProxNewton(
@@ -256,8 +258,6 @@ def test_CoxEstimator_sparse(use_efron, use_float_32):
256258
datafit = Cox(use_efron)
257259
penalty = L1(alpha)
258260

259-
datafit.initialize_sparse(X.data, X.indptr, X.indices, y)
260-
261261
*_, stop_crit = ProxNewton(
262262
fit_intercept=False, tol=1e-6, max_iter=50
263263
).solve(

skglm/tests/test_lbfgs_solver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def test_L2_Cox(use_efron):
6262
penalty = L2(alpha)
6363

6464
# XXX: intialize is needed here although it is done in LBFGS
65-
# is used to evaluate the objective
65+
# it is used to evaluate the objective
6666
datafit.initialize(X, y)
6767
w, *_ = LBFGS().solve(X, y, datafit, penalty)
6868

0 commit comments

Comments
 (0)