Skip to content

Commit 4041b1a

Browse files
run test on random values of y instead
1 parent a1302a5 commit 4041b1a

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

skglm/tests/test_estimators.py

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -635,22 +635,13 @@ def test_SLOPE_printing():
635635

636636

637637
@pytest.mark.parametrize(
638-
"sklearn_reg, skglm_datafit, y_gen",
639-
[
640-
(
641-
PoissonRegressor, Poisson,
642-
lambda X: np.random.poisson(np.exp(X.sum(axis=1) * 0.1))
643-
),
644-
(
645-
GammaRegressor, Gamma,
646-
lambda X: np.random.gamma(2.0, np.exp(X.sum(axis=1) * 0.1))
647-
),
648-
]
638+
"sklearn_reg, skglm_datafit",
639+
[(PoissonRegressor, Poisson), (GammaRegressor, Gamma)]
649640
)
650-
def test_inverse_link_prediction(sklearn_reg, skglm_datafit, y_gen):
641+
def test_inverse_link_prediction(sklearn_reg, skglm_datafit):
651642
np.random.seed(42)
652643
X = np.random.randn(20, 5)
653-
y = y_gen(X)
644+
y = np.random.randint(1, 6, size=20) # Use 1-6 for both (Gamma needs y>0)
654645
sklearn_pred = sklearn_reg(alpha=0.0, max_iter=10_000,
655646
tol=1e-8).fit(X, y).predict(X)
656647
skglm_pred = GeneralizedLinearEstimator(

0 commit comments

Comments
 (0)