Skip to content

Commit 7d7106c

Browse files
add fit_intercept=False to pytest, but failing
1 parent 2c84a44 commit 7d7106c

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

skglm/experimental/tests/test_quantile_huber.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66

77

88
@pytest.mark.parametrize('quantile', [0.3, 0.5, 0.7])
9-
def test_quantile_huber_matches_sklearn(quantile):
9+
@pytest.mark.parametrize('fit_intercept', [True, False])
10+
def test_quantile_huber_matches_sklearn(quantile, fit_intercept):
1011
"""Test that SmoothQuantileRegressor with small delta matches sklearn's
1112
QuantileRegressor."""
1213
X, y = make_regression(n_samples=1000, n_features=10, noise=0.1, random_state=42)
@@ -19,8 +20,9 @@ def test_quantile_huber_matches_sklearn(quantile):
1920
delta_final=0.00001,
2021
n_deltas=15,
2122
verbose=True,
22-
fit_intercept=True,
23+
fit_intercept=fit_intercept,
2324
).fit(X, y)
2425

2526
assert_allclose(smooth_est.coef_, sk_est.coef_, atol=1e-4)
26-
assert_allclose(smooth_est.intercept_, sk_est.intercept_, atol=1e-4)
27+
if fit_intercept:
28+
assert_allclose(smooth_est.intercept_, sk_est.intercept_, atol=1e-4)

0 commit comments

Comments
 (0)