fix some tests

Author: mathurinm

skglm/solvers/base.py

@@ -111,7 +111,9 @@ def solve(self, X, y, datafit, penalty, w_init=None, Xw_init=None,
                 "Do not pass a compiled datafit, compilation is done inside solver now")
         else:
             datafit = compiled_clone(datafit, to_float32=X.dtype == np.float32)
-            penalty = compiled_clone(penalty, to_float32=X.dtype == np.float32)
+            penalty = compiled_clone(penalty)
+            # TODO add support for bool spec in compiled_clone
+            # penalty = compiled_clone(penalty, to_float32=X.dtype == np.float32)
 
         if run_checks:
             self._validate(X, y, datafit, penalty)

skglm/tests/test_fista.py

@@ -3,11 +3,11 @@
 import numpy as np
 from numpy.linalg import norm
 
-from scipy.sparse import csc_matrix, issparse
+from scipy.sparse import csc_matrix
 
-from skglm.penalties import L1, IndicatorBox
+from skglm.penalties import L1
 from skglm.solvers import FISTA, AndersonCD
-from skglm.datafits import Quadratic, Logistic, QuadraticSVC
+from skglm.datafits import Quadratic, Logistic
 
 from skglm.utils.data import make_correlated_data
 
@@ -36,11 +36,6 @@
 def test_fista_solver(X, Datafit, Penalty):
     _y = y if isinstance(Datafit, Quadratic) else y_classif
     datafit = Datafit()
-    # _init = y @ X.T if isinstance(Datafit, QuadraticSVC) else X
-    # if issparse(X):
-    #     datafit.initialize_sparse(_init.data, _init.indptr, _init.indices, _y)
-    # else:
-    #     datafit.initialize(_init, _y)
     penalty = Penalty(alpha)
 
     solver = FISTA(max_iter=1000, tol=tol)

skglm/utils/jit_compilation.py

@@ -29,7 +29,9 @@ def spec_to_float32(spec):
             else:
                 dtype32 = dtype
         else:
-            raise ValueError(f"Unknown spec type {dtype}")
+            # raise ValueError(f"Unknown spec type {dtype}")
+            # bool types and others are not affected:
+            dtype32 = dtype
         spec32.append((name, dtype32))
     return spec32