Skip to content

Commit 8900c6f

Browse files
mathurinmKlopfeQB3Badr-MOUFAD
authored
[READY] remove inheritance from sklearn Lasso (#54)
* remove inheritance from sklearn Lasso * Revert "remove inheritance from sklearn Lasso" This reverts commit fe96a7f. * first try to remove sklearn inheritance * check_estimator ok Lasso * wLasso passes check_estimator * enet passes check_estimator * MCP passes check_estimator * Logreg passes check_estimator * [ci skip] fix docstring * push tests * fix pydocstyle error * Fixed first comments * Fixed more comments * handle n_iter differently * add warm_start * issues with warm_start * fix warm start for Lasso * split _glm_fit in _glm_reg_fit and _glm_clf_fit * training_vector >> training data * flake8 * flake8 * better formatting error msg wL1 * harmonized line break * add failing test warm start * first step towards SVC * First fix for SVC tests * Fix warm start * Fix warm start SVC * accept_large_sparse to False * rm path and use fit in GLE. multitask needs fixing * MultiTask needs fixing * fixes, ranming bcd_solver with same names * flake8 * flake8 * cleanup * [ci skip] back to _glm_fit, SVC has to be fixed again * fix is_classif for GLE * Revert "[ci skip] back to _glm_fit, SVC has to be fixed again" This reverts commit b45123e. * progress merging back * jit * revert again This reverts commit b45123e. * merged back glm_fit * flake8 * made check estimator pass * flake8 * CLN + questions * added all est in test_warm_start * some comment in test * rm test SVC * return _glm_fit once in fit GLM class * added a TODO for LinearSVC * call comiled penalty with a different name for isinstance checks to work * remove question SVC p0 * flake8 * rm commented code * cos: rm comments in test Co-authored-by: Klopfe <[email protected]> Co-authored-by: QB3 <[email protected]> Co-authored-by: Badr MOUFAD <[email protected]>
1 parent 212e60d commit 8900c6f

File tree

6 files changed

+396
-345
lines changed

6 files changed

+396
-345
lines changed

0 commit comments

Comments
 (0)