Skip to content

Commit 927df74

Browse files
authored
Merge pull request #24 from timstaley/Remove-scipy-numpy-preinstall-requirement
Remove unnecessary checks for numpy/scipy in setup.py.
2 parents b7d4869 + 8ad61fa commit 927df74

File tree

2 files changed

+2
-15
lines changed

2 files changed

+2
-15
lines changed

setup.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,6 @@
1-
import sys
21
from setuptools import setup, find_packages
32

43

5-
try:
6-
import numpy
7-
except ImportError:
8-
print('numpy is required during installation')
9-
sys.exit(1)
10-
11-
try:
12-
import scipy
13-
except ImportError:
14-
print('scipy is required during installation')
15-
sys.exit(1)
16-
174
setup(name='skope-rules',
185
version='1.0.0',
196
description='Machine Learning with Interpretable Rules',

skrules/tests/test_common.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44

55

66
def test_classifier():
7-
return check_estimator(SkopeRules)
7+
check_estimator(SkopeRules)
88

99

1010
def test_load_credit_data():
11-
return load_credit_data().data.shape[0] == 30000
11+
assert load_credit_data().data.shape[0] == 30000

0 commit comments

Comments
 (0)