Skip to content

Commit bd75cce

Browse files
committed
fix cif test and import name for ess.diffraction
1 parent a02d580 commit bd75cce

File tree

2 files changed

+27
-5
lines changed

2 files changed

+27
-5
lines changed

src/ess/dream/workflow.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ def default_parameters() -> dict:
6464
def _collect_reducer_software() -> ReducerSoftwares:
6565
return ReducerSoftwares(
6666
[
67-
Software.from_package_metadata('essdiffraction'),
67+
Software.from_package_metadata('ess.diffraction'),
68+
Software.from_package_metadata('ess.dream'),
69+
Software.from_package_metadata('ess.powder'),
6870
Software.from_package_metadata('scippneutron'),
6971
Software.from_package_metadata('scipp'),
7072
]

tests/dream/io/cif_test.py

Lines changed: 24 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,11 @@
66
import pytest
77
import scipp as sc
88
from scippneutron.io import cif
9+
from scippneutron.metadata import ESS_SOURCE, Person
910

1011
import ess.dream.io.cif
1112
from ess.powder.calibration import OutputCalibrationData
12-
from ess.powder.types import CIFAuthors, IofTof
13+
from ess.powder.types import Beamline, CIFAuthors, IofTof, ReducerSoftwares, Software
1314

1415

1516
@pytest.fixture
@@ -43,14 +44,33 @@ def save_reduced_tof_to_str(cif_: cif.CIF) -> str:
4344
def test_save_reduced_tof(ioftof: IofTof, cal: OutputCalibrationData) -> None:
4445
from ess.dream import __version__
4546

46-
author = cif.Author(name='John Doe')
47+
author = Person(name='John Doe', corresponding=True)
4748
cif_ = ess.dream.io.cif.prepare_reduced_tof_cif(
48-
ioftof, authors=CIFAuthors([author]), calibration=cal
49+
ioftof,
50+
authors=CIFAuthors([author]),
51+
beamline=Beamline(
52+
name="DREAM",
53+
facility="ESS",
54+
site="ESS",
55+
),
56+
source=ESS_SOURCE,
57+
reducers=ReducerSoftwares(
58+
[
59+
Software.from_package_metadata('ess.diffraction'),
60+
Software.from_package_metadata('ess.dream'),
61+
Software.from_package_metadata('ess.powder'),
62+
Software.from_package_metadata('scippneutron'),
63+
Software.from_package_metadata('scipp'),
64+
]
65+
),
66+
calibration=cal,
4967
)
5068
result = save_reduced_tof_to_str(cif_)
5169

5270
assert "_audit_contact_author.name 'John Doe'" in result
53-
assert f"_computing.diffrn_reduction 'ess.dream v{__version__}'" in result
71+
assert f"_computing.diffrn_reduction\n'ess.diffraction {__version__}'" in result
72+
assert f"ess.dream {__version__}" in result
73+
assert f"ess.powder {__version__}" in result
5474
assert '_diffrn_source.beamline DREAM' in result
5575
assert 'ZERO 0 0.2' in result
5676
assert 'DIFC 1 1.2' in result

0 commit comments

Comments
 (0)