Merge pull request #277 from scipp/fix-fake-beamline

jokasimr · web-flow · commit 3f9d0878eef1 · 2025-11-11T14:14:29.000+01:00
fix: change coordinate system consistently
diff --git a/src/ess/reduce/time_of_flight/fakes.py b/src/ess/reduce/time_of_flight/fakes.py
@@ -56,7 +56,7 @@ def __init__(
                 else tof_pkg.Clockwise,
                 open=ch.slit_begin,
                 close=ch.slit_end,
-                phase=abs(ch.phase),
+                phase=ch.phase if ch.frequency.value > 0.0 else -ch.phase,
                 distance=sc.norm(ch.axle_position - source_position),
                 name=name,
             )
diff --git a/src/ess/reduce/time_of_flight/lut.py b/src/ess/reduce/time_of_flight/lut.py
@@ -420,7 +420,7 @@ def simulate_chopper_cascade_using_tof(
             else tof.Clockwise,
             open=ch.slit_begin,
             close=ch.slit_end,
-            phase=abs(ch.phase),
+            phase=ch.phase if ch.frequency.value > 0.0 else -ch.phase,
             distance=sc.norm(
                 ch.axle_position - source_position.to(unit=ch.axle_position.unit)
             ),

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ def __init__(`
`56`	`56`	`else tof_pkg.Clockwise,`
`57`	`57`	`open=ch.slit_begin,`
`58`	`58`	`close=ch.slit_end,`
`59`		`- phase=abs(ch.phase),`
	`59`	`+ phase=ch.phase if ch.frequency.value > 0.0 else -ch.phase,`
`60`	`60`	`distance=sc.norm(ch.axle_position - source_position),`
`61`	`61`	`name=name,`
`62`	`62`	`)`