Save tof lookup table as a Datagroup that also contains chopper info #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We change the format of the tof lookup table from a DataArray to a DataGroup, which enable us to also save the chopper info as a nested DataGroup.
The chopper info is crucial to have alongside the table, so we can add validation when trying to use the table, that it applies for the correct chopper settings.
Note that unfortunately, this will break all workflows that currently use a tof lookup table stored in a hdf file.
See #212 for a discussion as to why in the end I went with scipp.DataGroup/hdf5 instead of a NeXus file.
Needs scipp/scippneutron#649 & scipp/tof#105