fix: create new parameter

Author: jokasimr

src/ess/amor/__init__.py

@@ -14,6 +14,7 @@
     NeXusDetectorName,
     RunType,
     SamplePosition,
+    BeamDivergenceLimits,
 )
 from . import conversions, data, load, orso, resolution, utils
 from .instrument_view import instrument_view
@@ -64,6 +65,7 @@ def default_parameters() -> dict:
         NeXusDetectorName[RunType]: "detector",
         ChopperPhase[RunType]: sc.scalar(-5.0, unit="deg"),
         ChopperFrequency[RunType]: sc.scalar(8.333, unit="Hz"),
+        BeamDivergenceLimits: (sc.scalar(-0.7, unit='deg'), sc.scalar(0.7, unit='deg')),
     }
 
 

src/ess/reflectometry/conversions.py

@@ -7,6 +7,7 @@
 from scippneutron.conversion.graph import beamline, tof
 
 from .types import (
+    BeamDivergenceLimits,
     DataWithScatteringCoordinates,
     Gravity,
     IncidentBeam,
@@ -148,10 +149,11 @@ def add_masks(
     ylim: YIndexLimits,
     wb: WavelengthBins,
     zlim: ZIndexLimits,
+    bdlim: BeamDivergenceLimits,
 ) -> MaskedData[RunType]:
-    da.masks["beam_divergence_too_large"] = sc.abs(
-        da.coords["angle_from_center_of_beam"]
-    ) > sc.scalar(0.7, unit='deg')
+    da.masks["beam_divergence_too_large"] = (
+        da.coords["angle_from_center_of_beam"] < bdlim[0]
+    ) | (da.coords["angle_from_center_of_beam"] > bdlim[1])
     da.masks["y_index_range"] = (da.coords["y_index"] < ylim[0]) | (
         da.coords["y_index"] > ylim[1]
     )

src/ess/reflectometry/types.py

@@ -124,5 +124,9 @@ class SampleSize(sciline.Scope[RunType, sc.Variable], sc.Variable):
 """Limit of the (logical) 'z' detector pixel index"""
 
 
+BeamDivergenceLimits = NewType("BeamDivergenceLimits", tuple[sc.Variable, sc.Variable])
+"""Limit of the beam divergence"""
+
+
 ReferenceFilePath = NewType("ReferenceFilePath", str)
 """Path to the cached normalization matrix"""