Skip to content

Commit bf074db

Browse files
Merge pull request #77 from scipp/use-new-hist-bin
Use new `scipp.bin` dim argument to avoid workaroundsUse new hist bin
2 parents f18c3c6 + f037eba commit bf074db

File tree

11 files changed

+60
-49
lines changed

11 files changed

+60
-49
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ dependencies = [
3737
"pythreejs",
3838
"orsopy",
3939
"sciline>=24.6.0",
40-
"scipp>=23.8.0",
40+
"scipp>=24.09.1", # Fixed new hist/bin API
4141
"scippneutron>=24.7.0",
4242
"essreduce",
4343
]

requirements/base.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ plopp
99
pythreejs
1010
orsopy
1111
sciline>=24.6.0
12-
scipp>=23.8.0
12+
scipp>=24.09.1
1313
scippneutron>=24.7.0
1414
essreduce

requirements/base.txt

Lines changed: 25 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# SHA1:03305bbd69a8ade40d4806be66defcfa33bb2197
1+
# SHA1:c59f85e6dbc38ae7eeef3ce1e4f681c07f43ff24
22
#
33
# This file is autogenerated by pip-compile-multi
44
# To update, run:
@@ -13,19 +13,21 @@ cloudpickle==3.0.0
1313
# via dask
1414
comm==0.2.2
1515
# via ipywidgets
16-
contourpy==1.2.1
16+
contourpy==1.3.0
1717
# via matplotlib
1818
cyclebane==24.6.0
1919
# via sciline
2020
cycler==0.12.1
2121
# via matplotlib
22-
dask==2024.8.0
22+
dask==2024.8.2
2323
# via -r base.in
2424
decorator==5.1.1
2525
# via ipython
26-
essreduce==24.8.0
26+
essreduce==24.9.0
2727
# via -r base.in
28-
executing==2.0.1
28+
exceptiongroup==1.2.2
29+
# via ipython
30+
executing==2.1.0
2931
# via stack-data
3032
fonttools==4.53.1
3133
# via matplotlib
@@ -37,19 +39,21 @@ h5py==3.11.0
3739
# via
3840
# scippneutron
3941
# scippnexus
42+
importlib-metadata==8.4.0
43+
# via dask
4044
ipydatawidgets==4.3.5
4145
# via pythreejs
42-
ipython==8.26.0
46+
ipython==8.27.0
4347
# via ipywidgets
44-
ipywidgets==8.1.3
48+
ipywidgets==8.1.5
4549
# via
4650
# ipydatawidgets
4751
# pythreejs
4852
jedi==0.19.1
4953
# via ipython
50-
jupyterlab-widgets==3.0.11
54+
jupyterlab-widgets==3.0.13
5155
# via ipywidgets
52-
kiwisolver==1.4.5
56+
kiwisolver==1.4.6
5357
# via matplotlib
5458
locket==1.0.0
5559
# via partd
@@ -63,7 +67,7 @@ mpltoolbox==24.5.1
6367
# via scippneutron
6468
networkx==3.3
6569
# via cyclebane
66-
numpy==2.0.1
70+
numpy==2.1.1
6771
# via
6872
# contourpy
6973
# h5py
@@ -100,7 +104,7 @@ pure-eval==0.2.3
100104
# via stack-data
101105
pygments==2.18.0
102106
# via ipython
103-
pyparsing==3.1.2
107+
pyparsing==3.1.4
104108
# via matplotlib
105109
python-dateutil==2.9.0.post0
106110
# via
@@ -113,8 +117,10 @@ pyyaml==6.0.2
113117
# via
114118
# dask
115119
# orsopy
116-
sciline==24.6.2
117-
# via -r base.in
120+
sciline==24.6.3
121+
# via
122+
# -r base.in
123+
# essreduce
118124
scipp==24.9.1
119125
# via
120126
# -r base.in
@@ -127,7 +133,7 @@ scippnexus==24.8.1
127133
# via
128134
# essreduce
129135
# scippneutron
130-
scipy==1.14.0
136+
scipy==1.14.1
131137
# via
132138
# scippneutron
133139
# scippnexus
@@ -151,7 +157,11 @@ traitlets==5.14.3
151157
# traittypes
152158
traittypes==0.2.1
153159
# via ipydatawidgets
160+
typing-extensions==4.12.2
161+
# via ipython
154162
wcwidth==0.2.13
155163
# via prompt-toolkit
156-
widgetsnbextension==4.0.11
164+
widgetsnbextension==4.0.13
157165
# via ipywidgets
166+
zipp==3.20.1
167+
# via importlib-metadata

requirements/basetest.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55
#
66
# pip-compile-multi
77
#
8-
certifi==2024.7.4
8+
certifi==2024.8.30
99
# via requests
1010
charset-normalizer==3.3.2
1111
# via requests
1212
exceptiongroup==1.2.2
1313
# via pytest
14-
idna==3.7
14+
idna==3.8
1515
# via requests
1616
iniconfig==2.0.0
1717
# via pytest

requirements/ci.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
#
66
# pip-compile-multi
77
#
8-
cachetools==5.4.0
8+
cachetools==5.5.0
99
# via tox
10-
certifi==2024.7.4
10+
certifi==2024.8.30
1111
# via requests
1212
chardet==5.2.0
1313
# via tox
@@ -25,7 +25,7 @@ gitdb==4.0.11
2525
# via gitpython
2626
gitpython==3.1.43
2727
# via -r ci.in
28-
idna==3.7
28+
idna==3.8
2929
# via requests
3030
packaging==24.1
3131
# via

requirements/dev.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ h11==0.14.0
4040
# via httpcore
4141
httpcore==1.0.5
4242
# via httpx
43-
httpx==0.27.0
43+
httpx==0.27.2
4444
# via jupyterlab
4545
isoduration==20.11.0
4646
# via jsonschema
@@ -67,7 +67,7 @@ jupyter-server==2.14.2
6767
# notebook-shim
6868
jupyter-server-terminals==0.5.3
6969
# via jupyter-server
70-
jupyterlab==4.2.4
70+
jupyterlab==4.2.5
7171
# via -r dev.in
7272
jupyterlab-server==2.27.3
7373
# via jupyterlab
@@ -115,7 +115,7 @@ terminado==0.18.1
115115
# jupyter-server-terminals
116116
toposort==1.10
117117
# via pip-compile-multi
118-
types-python-dateutil==2.9.0.20240316
118+
types-python-dateutil==2.9.0.20240821
119119
# via arrow
120120
uri-template==1.3.0
121121
# via jsonschema

requirements/docs.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ beautifulsoup4==4.12.3
2424
# pydata-sphinx-theme
2525
bleach==6.1.0
2626
# via nbconvert
27-
certifi==2024.7.4
27+
certifi==2024.8.30
2828
# via requests
2929
charset-normalizer==3.3.2
3030
# via requests
@@ -40,7 +40,7 @@ docutils==0.21.2
4040
# sphinx
4141
fastjsonschema==2.20.0
4242
# via nbformat
43-
idna==3.7
43+
idna==3.8
4444
# via requests
4545
imagesize==1.4.1
4646
# via sphinx
@@ -110,7 +110,7 @@ psutil==6.0.0
110110
# via ipykernel
111111
pydata-sphinx-theme==0.15.4
112112
# via -r docs.in
113-
pyzmq==26.1.0
113+
pyzmq==26.2.0
114114
# via
115115
# ipykernel
116116
# jupyter-client
@@ -139,7 +139,7 @@ sphinx==8.0.2
139139
# sphinx-autodoc-typehints
140140
# sphinx-copybutton
141141
# sphinx-design
142-
sphinx-autodoc-typehints==2.2.3
142+
sphinx-autodoc-typehints==2.3.0
143143
# via -r docs.in
144144
sphinx-copybutton==0.5.2
145145
# via -r docs.in

requirements/mypy.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
# pip-compile-multi
77
#
88
-r test.txt
9-
mypy==1.11.1
9+
mypy==1.11.2
1010
# via -r mypy.in
1111
mypy-extensions==1.0.0
1212
# via mypy

requirements/nightly.txt

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,19 @@ cloudpickle==3.0.0
1414
# via dask
1515
comm==0.2.2
1616
# via ipywidgets
17-
contourpy==1.2.1
17+
contourpy==1.3.0
1818
# via matplotlib
1919
cyclebane==24.6.0
2020
# via sciline
2121
cycler==0.12.1
2222
# via matplotlib
23-
dask==2024.8.0
23+
dask==2024.8.2
2424
# via -r nightly.in
2525
decorator==5.1.1
2626
# via ipython
27-
essreduce==24.8.0
27+
essreduce==24.9.0
2828
# via -r nightly.in
29-
executing==2.0.1
29+
executing==2.1.0
3030
# via stack-data
3131
fonttools==4.53.1
3232
# via matplotlib
@@ -38,21 +38,21 @@ h5py==3.11.0
3838
# via
3939
# scippneutron
4040
# scippnexus
41-
importlib-metadata==8.2.0
41+
importlib-metadata==8.4.0
4242
# via dask
4343
ipydatawidgets==4.3.5
4444
# via pythreejs
45-
ipython==8.26.0
45+
ipython==8.27.0
4646
# via ipywidgets
47-
ipywidgets==8.1.3
47+
ipywidgets==8.1.5
4848
# via
4949
# ipydatawidgets
5050
# pythreejs
5151
jedi==0.19.1
5252
# via ipython
53-
jupyterlab-widgets==3.0.11
53+
jupyterlab-widgets==3.0.13
5454
# via ipywidgets
55-
kiwisolver==1.4.5
55+
kiwisolver==1.4.6
5656
# via matplotlib
5757
locket==1.0.0
5858
# via partd
@@ -66,7 +66,7 @@ mpltoolbox==24.5.1
6666
# via scippneutron
6767
networkx==3.3
6868
# via cyclebane
69-
numpy==2.0.1
69+
numpy==2.1.1
7070
# via
7171
# contourpy
7272
# h5py
@@ -99,7 +99,7 @@ pure-eval==0.2.3
9999
# via stack-data
100100
pygments==2.18.0
101101
# via ipython
102-
pyparsing==3.1.2
102+
pyparsing==3.1.4
103103
# via matplotlib
104104
python-dateutil==2.9.0.post0
105105
# via
@@ -113,7 +113,9 @@ pyyaml==6.0.2
113113
# dask
114114
# orsopy
115115
sciline @ git+https://github.com/scipp/sciline@main
116-
# via -r nightly.in
116+
# via
117+
# -r nightly.in
118+
# essreduce
117119
scipp @ https://github.com/scipp/scipp/releases/download/nightly/scipp-nightly-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
118120
# via
119121
# -r nightly.in
@@ -127,7 +129,7 @@ scippnexus @ git+https://github.com/scipp/scippnexus@main
127129
# -r nightly.in
128130
# essreduce
129131
# scippneutron
130-
scipy==1.14.0
132+
scipy==1.14.1
131133
# via
132134
# scippneutron
133135
# scippnexus
@@ -155,7 +157,7 @@ typing-extensions==4.12.2
155157
# via ipython
156158
wcwidth==0.2.13
157159
# via prompt-toolkit
158-
widgetsnbextension==4.0.11
160+
widgetsnbextension==4.0.13
159161
# via ipywidgets
160-
zipp==3.20.0
162+
zipp==3.20.1
161163
# via importlib-metadata

src/ess/reflectometry/corrections.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def compute_reference_intensity(
5757
with the experiment parameters (such as sample rotation).
5858
Therefore it can be used to normalize sample measurements.
5959
"""
60-
b = da.bins.concat(set(da.dims) - set(da.coords["z_index"].dims)).bin(wavelength=wb)
60+
b = da.bin(wavelength=wb, dim=set(da.dims) - set(da.coords["z_index"].dims))
6161
h = b.hist()
6262
h.masks["too_few_events"] = h.data < sc.scalar(1, unit="counts")
6363
# Add a Q coordinate to each bin, the Q is not completely unique in every bin,

0 commit comments

Comments
 (0)