Skip to content

Commit e385213

Browse files
committed
Reduce WavelengthScaledQ instead of ReducedQ so direct-beam iteration works
1 parent 9c223c3 commit e385213

File tree

2 files changed

+17
-8
lines changed

2 files changed

+17
-8
lines changed

src/ess/sans/workflow.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,13 @@
2323
NeXusDetectorName,
2424
Numerator,
2525
PixelMaskFilename,
26-
ReducedQ,
2726
SampleRun,
2827
TransformationPath,
2928
Transmission,
3029
TransmissionRun,
3130
WavelengthBands,
3231
WavelengthMask,
32+
WavelengthScaledQ,
3333
)
3434

3535

@@ -99,8 +99,8 @@ def _set_runs(
9999
pipeline = pipeline.copy()
100100
runs = pd.DataFrame({Filename[key]: runs}).rename_axis(axis_name)
101101
for part in (Numerator, Denominator):
102-
pipeline[ReducedQ[key, part]] = (
103-
pipeline[ReducedQ[key, part]]
102+
pipeline[WavelengthScaledQ[key, part]] = (
103+
pipeline[WavelengthScaledQ[key, part]]
104104
.map(runs)
105105
.reduce(index=axis_name, func=merge_contributions)
106106
)

tests/loki/iofq_test.py

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@
2727
QBins,
2828
QxBins,
2929
QyBins,
30-
ReducedQ,
3130
ReturnEvents,
3231
SampleRun,
3332
UncertaintyBroadcastMode,
3433
WavelengthBands,
3534
WavelengthBins,
35+
WavelengthScaledQ,
3636
)
3737

3838
sys.path.insert(0, str(Path(__file__).resolve().parent))
@@ -251,13 +251,22 @@ def test_pipeline_IofQ_merging_events_yields_consistent_results():
251251
assert sc.identical(iofq1.coords['Q'], iofq3.coords['Q'])
252252
assert all(sc.variances(iofq1.data) > sc.variances(iofq3.data))
253253
assert sc.allclose(
254-
sc.values(pipeline_single.compute(ReducedQ[SampleRun, Numerator]).hist().data)
254+
sc.values(
255+
pipeline_single.compute(WavelengthScaledQ[SampleRun, Numerator]).hist().data
256+
)
255257
* N,
256-
sc.values(pipeline_triple.compute(ReducedQ[SampleRun, Numerator]).hist().data),
258+
sc.values(
259+
pipeline_triple.compute(WavelengthScaledQ[SampleRun, Numerator]).hist().data
260+
),
257261
)
258262
assert sc.allclose(
259-
sc.values(pipeline_single.compute(ReducedQ[SampleRun, Denominator]).data) * N,
260-
sc.values(pipeline_triple.compute(ReducedQ[SampleRun, Denominator]).data),
263+
sc.values(
264+
pipeline_single.compute(WavelengthScaledQ[SampleRun, Denominator]).data
265+
)
266+
* N,
267+
sc.values(
268+
pipeline_triple.compute(WavelengthScaledQ[SampleRun, Denominator]).data
269+
),
261270
)
262271

263272

0 commit comments

Comments
 (0)