Merge pull request #9 from scipp/fix-camera-position-zoom-after-pan

Fix camera position zoom after pan

Author: nvaytet

src/matplotgl/axes.py

@@ -38,9 +38,10 @@ def __init__(self, *, ax: MplAxes, figure=None) -> None:
         self.collections = []
         self.images = []
 
-        # Make background to enable box zoom
+        # Make background to enable box zoom.
+        # Use a size based on limits of the float32 range.
         self._background_geometry = p3.PlaneGeometry(
-            width=2, height=2, widthSegments=1, heightSegments=1
+            width=6e38, height=6e38, widthSegments=1, heightSegments=1
         )
         self._background_material = p3.MeshBasicMaterial(color=self.background_color)
         self._background_mesh = p3.Mesh(
@@ -329,18 +330,6 @@ def autoscale(self):
             else (1.0 if self.get_yscale() == "linear" else 10.0)
         )
 
-        self._background_mesh.geometry = p3.PlaneGeometry(
-            width=2 * (self._xmax - self._xmin),
-            height=2 * (self._ymax - self._ymin),
-            widthSegments=1,
-            heightSegments=1,
-        )
-
-        self._background_mesh.position = [
-            0.5 * (self._xmin + self._xmax),
-            0.5 * (self._ymin + self._ymax),
-            self._background_mesh.position[-1],
-        ]
         self.reset()
 
     def add_artist(self, artist):
@@ -503,8 +492,8 @@ def set_xlim(self, left, right=None):
             left = left[0]
         self._xmin = left
         self._xmax = right
-        self.camera.left = left
-        self.camera.right = right
+        self.camera.left = left - self.camera.position[0]
+        self.camera.right = right - self.camera.position[0]
         self._make_xticks()
 
     def get_ylim(self):
@@ -519,8 +508,8 @@ def set_ylim(self, bottom, top=None):
             bottom = bottom[0]
         self._ymin = bottom
         self._ymax = top
-        self.camera.bottom = bottom
-        self.camera.top = top
+        self.camera.bottom = bottom - self.camera.position[1]
+        self.camera.top = top - self.camera.position[1]
         self._make_yticks()
 
     def get_xticks(self):
@@ -577,10 +566,10 @@ def zoom(self, box):
             "ymax": box[3],
         }
         with self.camera.hold_trait_notifications():
-            self.camera.left = self._zoom_limits["xmin"]
-            self.camera.right = self._zoom_limits["xmax"]
-            self.camera.bottom = self._zoom_limits["ymin"]
-            self.camera.top = self._zoom_limits["ymax"]
+            self.camera.left = self._zoom_limits["xmin"] - self.camera.position[0]
+            self.camera.right = self._zoom_limits["xmax"] - self.camera.position[0]
+            self.camera.bottom = self._zoom_limits["ymin"] - self.camera.position[1]
+            self.camera.top = self._zoom_limits["ymax"] - self.camera.position[1]
         if self.get_xscale() == "log":
             xlim = (
                 10.0 ** self._zoom_limits["xmin"],