Merge pull request #84 from jorenham/mypy/scipy.signal

fix mypy errors in `scipy.signal`

Author: jorenham

.github/workflows/ci.yml

@@ -32,7 +32,7 @@ jobs:
 
       - uses: actions/setup-python@v5
         with:
-          python-version: "3.10"
+          python-version: "3.13"
           cache: poetry
 
       - name: install
@@ -44,7 +44,10 @@ jobs:
       - name: typetest
         run: poe typetest
 
-      - name: typecheck (partial)
+      - name: basedmypy
+        run: poe mypy
+
+      - name: basedpyright (partial)
         run: |
           targets=(
             "_lib"
@@ -62,7 +65,6 @@ jobs:
             "special"
           )
           for target in "${targets[@]}"; do
-            poe mypy $target
             poe pyright $target
           done
 

.pre-commit-config.yaml

@@ -7,6 +7,7 @@ ci:
     - ruff-format
     - verifytypes
     - typetest
+    - basedmypy
 
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
@@ -62,3 +63,9 @@ repos:
         language: system
         always_run: true
         pass_filenames: false
+
+      - id: basedmypy
+        name: basedmypy
+        entry: poe mypy
+        language: system
+        types_or: [python, pyi]

README.md

@@ -90,7 +90,7 @@ pip install scipy-stubs
 | `ndimage`     | :heavy_check_mark:    | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | :full_moon:            |
 | `odr`         | :heavy_check_mark:    | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | :waxing_crescent_moon: |
 | `optimize`    | :heavy_check_mark:    | :heavy_check_mark: | :heavy_check_mark: | :x:                | :first_quarter_moon:   |
-| `signal`      | :heavy_check_mark:    | :heavy_check_mark: | :x:                | :x:                | :waxing_crescent_moon: |
+| `signal`      | :heavy_check_mark:    | :heavy_check_mark: | :heavy_check_mark: | :x:                | :waxing_crescent_moon: |
 | `sparse`      | :heavy_check_mark:    | :heavy_check_mark: | :heavy_check_mark: | :x:                | :waxing_crescent_moon: |
 | `spatial`     | :heavy_check_mark:    | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | :waxing_gibbous_moon:  |
 | `special`     | :heavy_check_mark:    | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | :first_quarter_moon:   |

pyproject.toml

@@ -68,8 +68,8 @@ cmd = "basedpyright scipy-stubs/$path"
 args = [{name = "path", positional = true, multiple = false, default = ""}]
 
 [tool.poe.tasks.mypy]
-cmd = "mypy --config-file=pyproject.toml scipy-stubs/$path"
-args = [{name = "path", positional = true, multiple = false, default = ""}]
+cmd = "mypy --config-file=pyproject.toml $path"
+args = [{name = "path", positional = true, multiple = true, default = "scipy-stubs"}]
 
 [tool.poe.tasks.stubtest]
 cmd = """

scipy-stubs/signal/_ltisys.pyi

@@ -46,10 +46,6 @@ class lti(LinearTimeInvariant):
 class dlti(LinearTimeInvariant):
     def __new__(cls, *system, **kwargs) -> Self: ...
     def __init__(self, *system, **kwargs) -> None: ...
-    @property
-    def dt(self) -> Untyped: ...
-    @dt.setter
-    def dt(self, dt) -> None: ...
     def impulse(self, x0: Untyped | None = None, t: Untyped | None = None, n: Untyped | None = None) -> Untyped: ...
     def step(self, x0: Untyped | None = None, t: Untyped | None = None, n: Untyped | None = None) -> Untyped: ...
     def output(self, u, t, x0: Untyped | None = None) -> Untyped: ...
@@ -85,14 +81,6 @@ class ZerosPolesGain(LinearTimeInvariant):
     def __new__(cls, *system, **kwargs) -> Self: ...
     def __init__(self, *system, **kwargs) -> None: ...
     @property
-    def zeros(self) -> Untyped: ...
-    @zeros.setter
-    def zeros(self, zeros) -> None: ...
-    @property
-    def poles(self) -> Untyped: ...
-    @poles.setter
-    def poles(self, poles) -> None: ...
-    @property
     def gain(self) -> Untyped: ...
     @gain.setter
     def gain(self, gain) -> None: ...