✨ integrate: improve the odeint signature
#763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the type signature for the odeint function in scipy-stubs by providing more precise type annotations, better parameter handling, and enhanced type safety. The changes focus on making the function signatures more accurate and comprehensive.
Key changes:
- Refactored function type annotations to use TypeAlias and more specific return types
- Moved and updated the ODEInfoDict definition to be more accurate
- Added comprehensive overloads to handle different parameter combinations properly
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/integrate/test_odeint.pyi |
Added comprehensive type tests covering various odeint usage patterns with different function signatures and parameter combinations |
scipy-stubs/integrate/_typing.pyi |
Removed the ODEInfoDict class as it was moved to the specific module files |
scipy-stubs/integrate/_odepack_py.pyi |
Major refactor of odeint overloads with improved type aliases, more precise parameter types, and better handling of function signatures |
scipy-stubs/integrate/_odepack.pyi |
Updated the private odeint function signature with more accurate types and proper overloads |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.