🐛✨ sparse: fix and improve the lil_matrix and lil_array constructors
#818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes and improves the type annotations for the lil_matrix and lil_array constructors in the scipy sparse module. The changes address issue #817 by refining type handling and constructor overloads.
Key changes include:
- Replaced
op.CanIndexandop.JustInt/JustFloat/JustComplexwith standard library equivalents (SupportsIndex,int,float,complex) - Added new type alias
_ToAnyLILto better handle constructor arguments - Enhanced constructor overloads for better dtype inference with specific numeric types
- Added comprehensive test coverage for the improved constructors
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
scipy-stubs/sparse/_lil.pyi |
Improves type annotations for lil_matrix and lil_array constructors, replaces optype dependencies with standard library types, and adds new overloads for better dtype handling |
tests/sparse/test_lil.pyi |
Adds comprehensive type tests for the improved lil_matrix and lil_array constructors covering various input types and dtype specifications |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #817