Merge pull request #110 from ev-br/pytest_warns

MAINT: avoid pytest future warnings

Author: ev-br

scpdt/tests/test_testmod.py

@@ -17,77 +17,73 @@
                failure_cases,
                failure_cases_2,
                local_file_cases)
-from ..frontend import testmod, find_doctests, run_docstring_examples
+from ..frontend import testmod as _testmod, find_doctests, run_docstring_examples
 from ..util import warnings_errors
 from ..impl import DTConfig
 
 _VERBOSE = 2
 
 
 def test_module():
-    res, _ = testmod(module, verbose=_VERBOSE)
-    if res.failed != 0 or res.attempted == 0:
-        raise RuntimeError("Test_module(DTFinder) failed)")
-    return res
+    res, _ = _testmod(module, verbose=_VERBOSE)
+    assert res.failed == 0
+    assert res.attempted != 0
 
 
 def test_module_vanilla_dtfinder():
     config = DTConfig()
     config.stopwords = []
-    res, _ = testmod(module, verbose=_VERBOSE, config=config)
-    if res.failed != 0 or res.attempted == 0:
-        raise RuntimeError("Test_module(vanilla DocTestFinder) failed)")
-    return res
+    res, _ = _testmod(module, verbose=_VERBOSE, config=config)
+    assert res.failed == 0
+    assert res.attempted != 0
 
 
 def test_stopwords():
-    res, _ = testmod(stopwords, verbose=_VERBOSE)
-    if res.failed != 0 or res.attempted == 0:
-        raise RuntimeError("Test_stopwords failed.")
-    return res
+    res, _ = _testmod(stopwords, verbose=_VERBOSE)
+    assert res.failed == 0
+    assert res.attempted != 0
 
 
 def test_public_obj_discovery():
-    res, _ = testmod(module, verbose=_VERBOSE, strategy='api')
-    if res.failed != 0 or res.attempted == 0:
-        raise RuntimeError("Test_public_obj failed.")
-    return res
+    res, _ = _testmod(module, verbose=_VERBOSE, strategy='api')
+    assert res.failed == 0
+    assert res.attempted != 0
 
 
 def test_run_docstring_examples():
     f = finder_cases.Klass
     res1 = run_docstring_examples(f)
-    res2 = testmod(finder_cases, strategy=[finder_cases.Klass])
+    res2 = _testmod(finder_cases, strategy=[finder_cases.Klass])
     assert res1 == res2
 
 
 def test_global_state():
     # Make sure doctesting does not alter the global state, as much as reasonable
     objs = [module.manip_printoptions]
     opts = np.get_printoptions()
-    testmod(module)
+    _testmod(module)
     new_opts = np.get_printoptions()
     assert new_opts == opts
 
 
 def test_module_debugrunner():
     with pytest.raises((doctest.UnexpectedException, doctest.DocTestFailure)):
-        res = testmod(failure_cases, raise_on_error=True)
+        res = _testmod(failure_cases, raise_on_error=True)
 
 
 def test_verbosity_1():
     # smoke test that verbose=1 works
     stream = io.StringIO()
     with redirect_stderr(stream):
-        testmod(failure_cases, verbose=1, report=False)
+        _testmod(failure_cases, verbose=1, report=False)
 
 
 def test_user_context():
     # use a user context to turn warnings to errors : test that it raises
     config = DTConfig()
     config.user_context_mgr = warnings_errors
     with pytest.raises(doctest.UnexpectedException):
-        testmod(failure_cases_2,
+        _testmod(failure_cases_2,
                 raise_on_error=True, strategy=[failure_cases_2.func_depr],
                 config=config)
 
@@ -99,23 +95,25 @@ def test_local_files(self):
         config = DTConfig()
         config.local_resources = {'scpdt.tests.local_file_cases.local_files':
                                   ['local_file.txt']}
-        res, _ = testmod(local_file_cases, config=config,
+        res, _ = _testmod(local_file_cases, config=config,
                          strategy=[local_file_cases.local_files],
                          verbose=_VERBOSE)
-        if res.failed != 0 or res.attempted == 0:
-            raise RuntimeError("Test_module::test_local_files")
+
+        assert res.failed == 0
+        assert res.attempted != 0
 
     @pytest.mark.skipif(not HAVE_SCIPY, reason='need scipy')
     def test_sio_octave(self):
         # scipy/tutorial/io.rst : octave_a.mat file
         config = DTConfig()
         config.local_resources = {'scpdt.tests.local_file_cases.sio':
                                   ['octave_a.mat']}
-        res, _ = testmod(local_file_cases, config=config,
-                         strategy=[local_file_cases.sio],
-                         verbose=_VERBOSE)
-        if res.failed != 0 or res.attempted == 0:
-            raise RuntimeError("Test_module::sio")
+        res, _ = _testmod(local_file_cases, config=config,
+                          strategy=[local_file_cases.sio],
+                          verbose=_VERBOSE)
+
+        assert res.failed == 0
+        assert res.attempted != 0
 
 
 class TestNameErrorAfterException:
@@ -125,8 +123,8 @@ def test_name_error_after_exception(self):
         # This first came in in https://github.com/scipy/scipy/pull/13116
         stream = io.StringIO()
         with redirect_stderr(stream):
-            testmod(failure_cases_2,
-                    strategy=[failure_cases_2.func_name_error])
+            _testmod(failure_cases_2,
+                     strategy=[failure_cases_2.func_name_error])
 
         stream.seek(0)
         output = stream.read()
@@ -139,8 +137,8 @@ def test_name_error_after_exception_off(self):
         config = DTConfig(nameerror_after_exception=True)
         stream = io.StringIO()
         with redirect_stderr(stream):
-            testmod(failure_cases_2,
-                    strategy=[failure_cases_2.func_name_error], config=config)
+            _testmod(failure_cases_2,
+                     strategy=[failure_cases_2.func_name_error], config=config)
 
         stream.seek(0)
         output = stream.read()