MAINT: run ruff w/ default config, fix reported violations

Author: ev-br

scpdt/plugin.py

@@ -2,18 +2,17 @@
 A pytest plugin that provides enhanced doctesting for Pydata libraries
 """
 import bdb
-import os
-import shutil
 import warnings
 import doctest
 
 
 import pytest
-from _pytest import doctest as pydoctest, mark, outcomes
+import _pytest
+from _pytest import doctest as pydoctest, outcomes
 from _pytest.doctest import DoctestModule, DoctestTextfile
 from _pytest.pathlib import import_path
 
-from scpdt.impl import DTChecker, DTParser, DebugDTRunner
+from scpdt.impl import DTParser, DebugDTRunner
 from scpdt.conftest import dt_config
 from scpdt.util import np_errstate, matplotlib_make_nongui, temp_cwd
 from scpdt.frontend import find_doctests
@@ -85,7 +84,7 @@ def _maybe_add_markers(item, config):
 
     extra_skip = dt_config.pytest_extra_skip
     skip_it = item.name in extra_skip
-    if item.name in extra_skip:
+    if skip_it:
         reason = extra_skip[item.name] or ''
         item.add_marker(
             pytest.mark.skip(reason=reason)
@@ -163,7 +162,7 @@ def _is_deprecated(module):
 
     res = False
     try:
-        with warnings.catch_warnings() as w:
+        with warnings.catch_warnings():
             warnings.simplefilter('error', DeprecationWarning)
             getattr(module, names[0])
             res = False

scpdt/tests/test_parser.py

@@ -1,4 +1,4 @@
-from ..impl import DTConfig, DTParser, DebugDTRunner
+from ..impl import DTConfig, DTParser
 
 
 def test_parser_default_config():

scpdt/tests/test_pytest_configuration.py

@@ -12,7 +12,7 @@
 except Exception:
     HAVE_SCIPY = False
 
-from pathlib import PosixPath, Path
+from pathlib import Path
 
 from . import module_cases, failure_cases, failure_cases_2, stopwords_cases, local_file_cases
 

scpdt/tests/test_runner.py

@@ -99,7 +99,7 @@ def test_vanilla_checker(self):
         runner = DebugDTRunner(config=config)
         tests = DTFinder().find(module_cases.func)
 
-        with pytest.raises(doctest.DocTestFailure) as exc:
+        with pytest.raises(doctest.DocTestFailure):
             for t in tests:
                 runner.run(t)
 

scpdt/tests/test_testmod.py

@@ -6,7 +6,7 @@
 import numpy as np
 
 try:
-    import matplotlib.pyplot as plt
+    import matplotlib.pyplot as plt    # noqa
     HAVE_MATPLOTLIB = True
 except Exception:
     HAVE_MATPLOTLIB = False