Testing httpd-2.4 container by PyTest #234

phracek · 2024-11-27T12:02:52Z

No description provided.

github-actions · 2024-11-27T12:04:24Z

Pull Request validation

Failed

🔴 Review - Missing review from a member (1 required)

Success

🟢 CI - All checks have passed

The working solution can be seen here sclorg/httpd-container#234 Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek · 2024-11-28T10:36:05Z

See the output from local testing:

====================================================================== short test summary info =======================================================================
PASSED test/container/test_httpd.py::TestHttpdAppContainer::test_default_path
PASSED test/container/test_httpd.py::TestHttpdAppContainer::test_run_as_root
PASSED test/container/test_httpd.py::TestHttpdAppContainer::test_run_s2i_usage
PASSED test/container/test_httpd_s2i.py::TestHttpdS2IPreInitContainer::test_run_pre_init_test[/root/httpd-container/2.4/test/container/../pre-init-test-app]
PASSED test/container/test_httpd_s2i.py::TestHttpdS2ISampleAppContainer::test_self_cert_test[/root/httpd-container/2.4/test/container/../sample-test-app]
========================================================================= 5 passed in 25.05s =========================================================================

The working solution can be seen here sclorg/httpd-container#234 Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek · 2025-08-26T15:55:55Z

[test-pytest]

github-actions · 2025-08-26T16:02:15Z

Testing Farm results

name	compose	arch	status	started (UTC)	time	logs
CentOS Stream 10 - 2.4-micro	CentOS-Stream-10	x86_64	❌ error	26.08.2025 15:56:07	5min 42s	test pipeline

github-actions · 2025-08-26T16:02:15Z

Testing Farm results

name	compose	arch	status	started (UTC)	time	logs
CentOS Stream 10 - 2.4	CentOS-Stream-10	x86_64	❌ error	26.08.2025 15:56:05	5min 55s	test pipeline

github-actions · 2025-08-26T16:02:15Z

Testing Farm results

name	compose	arch	status	started (UTC)	time	logs
Fedora - 2.4-micro	Fedora-latest	x86_64	✅ passed	01.09.2025 14:00:31	54min 55s	test pipeline
Fedora - 2.4	Fedora-latest	x86_64	✅ passed	01.09.2025 14:00:33	14min 15s	test pipeline
CentOS Stream 9 - 2.4-micro	CentOS-Stream-9	x86_64	✅ passed	01.09.2025 14:00:32	55min 38s	test pipeline
CentOS Stream 9 - 2.4	CentOS-Stream-9	x86_64	✅ passed	01.09.2025 14:00:33	55min 29s	test pipeline
RHEL8 - PyTest - 2.4	RHEL-8.10.0-Nightly	x86_64	✅ passed	29.09.2025 11:17:25	21min 44s	test pipeline
RHEL9 - PyTest - 2.4	RHEL-9.6.0-Nightly	x86_64	✅ passed	29.09.2025 11:17:27	24min 48s	test pipeline
RHEL10 - PyTest - 2.4	RHEL-10-Nightly	x86_64	✅ passed	29.09.2025 11:17:26	19min 35s	test pipeline
CentOS Stream 10 - 2.4	CentOS-Stream-10	x86_64	✅ passed	01.09.2025 14:00:33	54min 45s	test pipeline
CentOS Stream 10 - 2.4-micro	CentOS-Stream-10	x86_64	✅ passed	27.08.2025 15:09:45	5min 26s	test pipeline
RHEL10 - 2.4	RHEL-10-Nightly	x86_64	✅ passed	01.09.2025 14:00:30	12min 40s	test pipeline
RHEL8 - 2.4	RHEL-8.10.0-Nightly	x86_64	✅ passed	01.09.2025 14:00:32	16min 53s	test pipeline
RHEL9 - 2.4	RHEL-9.6.0-Nightly	x86_64	✅ passed	01.09.2025 14:00:30	16min 59s	test pipeline
Fedora - PyTest - 2.4	Fedora-latest	x86_64	✅ passed	29.09.2025 11:17:24	7min 50s	test pipeline
CentOS Stream 10 - PyTest - 2.4	CentOS-Stream-10	x86_64	✅ passed	29.09.2025 11:17:27	8min 48s	test pipeline
CentOS Stream 9 - PyTest - 2.4	CentOS-Stream-9	x86_64	✅ passed	29.09.2025 11:17:25	10min 39s	test pipeline
Fedora - PyTest - 2.4-micro	Fedora-latest	x86_64	✅ passed	29.09.2025 11:17:26	7min 44s	test pipeline
CentOS Stream 9 - PyTest - 2.4-micro	CentOS-Stream-9	x86_64	✅ passed	29.09.2025 11:17:26	10min 26s	test pipeline
CentOS Stream 10 - PyTest - 2.4-micro	CentOS-Stream-10	x86_64	✅ passed	29.09.2025 11:17:24	9min 18s	test pipeline

phracek · 2025-08-27T07:19:32Z

[test]

phracek · 2025-08-27T07:47:33Z

[test-pytest]

phracek · 2025-08-28T06:26:13Z

[test-pytest]

phracek · 2025-08-29T08:34:19Z

[test-pytest]

phracek · 2025-09-01T07:11:33Z

/auto-merge

Co-authored-by: Karolina Surma <[email protected]>

frenzymadness

First round done by me. I have checked mostly the test_container_httpd so far.

test/run-pytest

test/test_container_httpd.py

Co-authored-by: Lumír 'Frenzy' Balhar <[email protected]>

frenzymadness

Some more ideas from me. Feel free to ping me if you'd like to talk about some of the design ideas further.

test/constants.py

test/test_container_httpd_s2i.py

test/test_container_ssl.py

Remove fixtures. They are not needed. Signed-off-by: Petr "Stone" Hracek <[email protected]>

In case of podman exec failed, then return is False instead of silence failure Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek · 2025-09-25T09:07:19Z

[test-pytest]

frenzymadness

Next round of review. Thanks for your patience.

test/test_container_httpd.py

test/test_container_httpd_s2i.py

test/test_container_ssl.py

Co-authored-by: Lumír 'Frenzy' Balhar <[email protected]>

The whole suite was added to test_container_httpd_s2i.py. Also building new image is called by new function. Now each class use this function. Check of SSL should pass with proper response. Signed-off-by: Petr "Stone" Hracek <[email protected]>

Signed-off-by: Petr "Stone" Hracek <[email protected]>

like IMAGE_NAME, OS, VERSION and import them in PyTest suite Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek · 2025-09-29T11:17:13Z

let's try for another round of tests

[test-pytest]

phracek · 2025-09-30T17:20:45Z

/auto-merge

frenzymadness

Thank you for your patience and all the changes you've made to make this testsuite better. I think we are good to merge it.

frenzymadness · 2025-09-29T10:04:32Z

test/test_container_httpd.py

+if not check_variables():
+    sys.exit(1)
+
+
+TEST_DIR = Path(__file__).parent.absolute()
+VERSION = os.getenv("VERSION")
+OS = os.getenv("OS").lower()
+IMAGE_NAME = os.getenv("IMAGE_NAME")


As I already mentioned elsewhere, you can de-duplicate this part by moving it to a new module settings.py and importing back only the required variables into this module.

For example: OS and VERSION are both unused here.

phracek marked this pull request as draft November 27, 2024 12:02

github-actions bot added the pr/missing-review label Nov 27, 2024

phracek added a commit to sclorg/container-ci-suite that referenced this pull request Nov 28, 2024

Fixed support for building s2i images.

50a90a1

The working solution can be seen here sclorg/httpd-container#234 Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek force-pushed the container_pytests branch 2 times, most recently from 0b2286b to c011dbf Compare December 3, 2024 14:09

phracek added a commit to sclorg/container-ci-suite that referenced this pull request Dec 3, 2024

Fixed support for building s2i images.

fc53559

The working solution can be seen here sclorg/httpd-container#234 Signed-off-by: Petr "Stone" Hracek <[email protected]>

phracek force-pushed the container_pytests branch from c011dbf to cf881c4 Compare August 26, 2025 15:26

phracek marked this pull request as ready for review August 26, 2025 15:27

github-actions bot added the pr/failing-ci label Aug 26, 2025

phracek force-pushed the container_pytests branch from a05d74a to 8643b65 Compare August 27, 2025 08:05

github-actions bot added pr/failing-ci and removed pr/failing-ci labels Aug 27, 2025

phracek force-pushed the container_pytests branch from 5e407b0 to 3dc41cd Compare August 28, 2025 06:18

github-actions bot removed the pr/failing-ci label Aug 28, 2025

phracek force-pushed the container_pytests branch 2 times, most recently from 0ed2766 to 25ed922 Compare August 28, 2025 06:26

github-actions bot added the pr/failing-ci label Aug 28, 2025

github-actions bot removed the pr/failing-ci label Sep 23, 2025

Remove leftovers.

1b6e27d

Co-authored-by: Karolina Surma <[email protected]>

frenzymadness reviewed Sep 23, 2025

View reviewed changes

phracek and others added 2 commits September 23, 2025 16:03

app is not parametrized

db4b466

Co-authored-by: Lumír 'Frenzy' Balhar <[email protected]>

assert output and not check empty string.

0ad18a8

Co-authored-by: Lumír 'Frenzy' Balhar <[email protected]>

frenzymadness reviewed Sep 24, 2025

View reviewed changes

phracek added 2 commits September 24, 2025 15:19

Remove function from constants.py.

83e280e

Remove fixtures. They are not needed. Signed-off-by: Petr "Stone" Hracek <[email protected]>

Update tests suite and use new shell command.

8862757

In case of podman exec failed, then return is False instead of silence failure Signed-off-by: Petr "Stone" Hracek <[email protected]>

github-actions bot added the pr/failing-ci label Sep 25, 2025

phracek changed the title ~~First PoC for testing httpd-2.4 container by PyTest~~ Testing httpd-2.4 container by PyTest Sep 25, 2025

frenzymadness reviewed Sep 26, 2025

View reviewed changes

phracek and others added 3 commits September 26, 2025 15:22

Update test/test_container_ssl.py

ff56ad5

Co-authored-by: Lumír 'Frenzy' Balhar <[email protected]>

Update test/test_container_httpd.py

8760afb

Co-authored-by: Lumír 'Frenzy' Balhar <[email protected]>

Update test/test_container_httpd.py

2cd3c34

Co-authored-by: Lumír 'Frenzy' Balhar <[email protected]>

github-actions bot removed the pr/failing-ci label Sep 26, 2025

phracek and others added 5 commits September 26, 2025 15:23

Update test/test_container_httpd.py

c30c0fa

Co-authored-by: Lumír 'Frenzy' Balhar <[email protected]>

Update test/test_container_httpd.py

652a4b8

Co-authored-by: Lumír 'Frenzy' Balhar <[email protected]>

Update comments in PyTest suite.

f292ca0

Signed-off-by: Petr "Stone" Hracek <[email protected]>

Add settings.py that gets environment variables

5b8ad70

like IMAGE_NAME, OS, VERSION and import them in PyTest suite Signed-off-by: Petr "Stone" Hracek <[email protected]>

github-actions bot added the pr/failing-ci label Sep 29, 2025

github-actions bot removed the pr/failing-ci label Sep 30, 2025

frenzymadness approved these changes Oct 1, 2025

View reviewed changes

phracek added the READY-to-MERGE label Oct 1, 2025

phracek merged commit 4643c8d into master Oct 1, 2025
10 checks passed

phracek deleted the container_pytests branch October 1, 2025 09:00

phracek mentioned this pull request Oct 9, 2025

Container pytests sclorg/s2i-perl-container#346

Merged

Testing httpd-2.4 container by PyTest #234

Testing httpd-2.4 container by PyTest #234

Uh oh!

Conversation

phracek commented Nov 27, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request validation

Failed

Success

Uh oh!

phracek commented Nov 28, 2024

Uh oh!

phracek commented Aug 26, 2025

Uh oh!

github-actions bot commented Aug 26, 2025

Testing Farm results

Uh oh!

github-actions bot commented Aug 26, 2025

Testing Farm results

Uh oh!

github-actions bot commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Farm results

Uh oh!

phracek commented Aug 27, 2025

Uh oh!

phracek commented Aug 27, 2025

Uh oh!

phracek commented Aug 28, 2025

Uh oh!

phracek commented Aug 29, 2025

Uh oh!

phracek commented Sep 1, 2025

Uh oh!

frenzymadness left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

frenzymadness left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

phracek commented Sep 25, 2025

Uh oh!

frenzymadness left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

phracek commented Sep 29, 2025

Uh oh!

phracek commented Nov 27, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Aug 26, 2025 •

edited

Loading