-
Notifications
You must be signed in to change notification settings - Fork 125
Update README's, remove SCL and fix usage #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
test/run also checks if SCL is running. It is not valid anymore Signed-off-by: Petr "Stone" Hracek <[email protected]>
Add to examples Dockerfile and Dockerfile.s2i notes what source-to-image means Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Pull Request validationFailed🔴 Failed or pending statuses:
🔴 Review - Missing review from a member (1 required) |
Member
Author
|
[test-all] |
Testing Farm results
|
Member
Author
|
/auto-merge |
Member
Author
Member
Author
|
@pkubatrh PTAL |
Contributor
|
LGTM, thanks @phracek |
notroj
approved these changes
Sep 10, 2025
Contributor
|
You modified some files in 2.4-micro and it seems it's still shipped in quay.io, but you did not update the README.md to reflect those changes as you did in 2.4. Should it be updated, too? |
pkhartsk
reviewed
Sep 10, 2025
As 2.4-micro is not available in RHEL land. Let's use CentOS Stream 9 in README.md Signed-off-by: Petr "Stone" Hracek <[email protected]>
Member
Author
|
[test-all] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates README.md files
Remove SCL stuff from container.
Removes also CentOS7 and RHEL7 containers.
Updates imagestreams.