Add mariadb 11.8 by ndavidova · Pull Request #288 · sclorg/mariadb-container

ndavidova · 2025-08-21T11:54:42Z

No description provided.

github-actions · 2025-08-21T11:55:16Z

Pull Request validation

Failed

🔴 Failed or pending statuses:

Testing Farm - RHEL9 - 10.11[pending]
Testing Farm - RHEL8 - 10.11[pending]
Testing Farm - RHEL8 - 10.3[pending]
Testing Farm - RHEL9 - 10.5[pending]

Success

🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved

phracek · 2025-08-21T13:37:22Z

[test]

github-actions · 2025-08-21T13:45:46Z

Testing Farm results

name	compose	arch	status	started (UTC)	time	logs
CentOS Stream 10 - 11.8	CentOS-Stream-10	x86_64	❌ error	21.08.2025 13:37:32	6min 24s	test pipeline
CentOS Stream 9 - 11.8	CentOS-Stream-9	x86_64	❌ error	21.08.2025 13:37:40	7min 3s	test pipeline
CentOS Stream 9 - 10.5	CentOS-Stream-9	x86_64	✅ passed	11.09.2025 13:37:44	10min 18s	test pipeline
CentOS Stream 9 - 10.11	CentOS-Stream-9	x86_64	✅ passed	12.09.2025 09:37:24	11min 24s	test pipeline
CentOS Stream 10 - 10.11	CentOS-Stream-10	x86_64	✅ passed	12.09.2025 09:37:23	10min 1s	test pipeline
Fedora - 11.8	Fedora-latest	x86_64	✅ passed	12.09.2025 09:37:29	9min 28s	test pipeline
RHEL10 - 11.8	RHEL-10-Nightly	x86_64	❌ error	21.08.2025 13:37:34	11min 58s	test pipeline
RHEL8 - 11.8	RHEL-8.10.0-Nightly	x86_64	❌ error	21.08.2025 13:37:34	12min 34s	test pipeline
RHEL9 - 11.8	RHEL-9.6.0-Nightly	x86_64	❌ error	21.08.2025 13:37:42	14min 36s	test pipeline
RHEL8 - 10.5	RHEL-8.10.0-Nightly	x86_64	✅ passed	12.09.2025 09:37:24	17min 4s	test pipeline
RHEL10 - 10.11	RHEL-10-Nightly	x86_64	✅ passed	12.09.2025 09:37:28	14min 12s	test pipeline
RHEL9 - 10.11	RHEL-9.6.0-Nightly	x86_64	✅ passed	12.09.2025 09:37:21	20min 58s	test pipeline
RHEL8 - 10.3	RHEL-8.10.0-Nightly	x86_64	✅ passed	12.09.2025 09:37:24	19min 3s	test pipeline
RHEL9 - 10.5	RHEL-9.6.0-Nightly	x86_64	✅ passed	11.09.2025 13:37:41	21min 5s	test pipeline
Fedora - 10.11	Fedora-latest	x86_64	✅ passed	12.09.2025 09:37:21	9min 3s	test pipeline
RHEL8 - 10.11	RHEL-8.10.0-Nightly	x86_64	✅ passed	12.09.2025 09:37:21	18min 44s	test pipeline

phracek

Thanks for this pull request.

It looks good. Please add to folder 11.8 exclude files that are not build and not tested.
Like .exclude-rhel9 . Only Fedora is going to be build and tested for now.

phracek · 2025-08-25T06:36:36Z

Fedora 11.8 has failed for this reason:

-----------------------------------------------
Running test run_change_password_test (starting at 2025-08-21 13:44:29+00:00) ... 
-----------------------------------------------
    Created container 6ef44a0eea6e40bf3bcdbd3d54fd0aaf36a336ff06ac7ad9fe1264215db6bcc7
  Testing MySQL connection to 10.88.0.90...
    Trying to connect.... FAIL
  Giving up: Failed to connect.
Error: no such object: "testpass1"
  Container finised with exit code .
Logs:
=> sourcing 20-validate-variables.sh ...
=> sourcing 25-validate-replication-variables.sh ...
=> sourcing 30-base-config.sh ...
---> 13:44:29     Processing basic MySQL configuration files ...
=> sourcing 60-replication-config.sh ...
=> sourcing 70-s2i-config.sh ...
---> 13:44:29     Processing additional arbitrary  MySQL configuration provided by s2i ...
=> sourcing 40-paas.cnf ...
=> sourcing 50-my-tuning.cnf ...
---> 13:44:29     Initializing database ...
---> 13:44:29     Running mysql_install_db ...
/usr/bin/mysql_install_db: Deprecated program name. It will be removed in a future release, use 'mariadb-install-db' instead


PLEASE REMEMBER TO SET A PASSWORD FOR THE MariaDB root USER !
To do so, start the server, then issue the following command:

'/usr/bin/mariadb-secure-installation'

which will also give you the option of removing the test
databases and anonymous user created by default.  This is
strongly recommended for production servers.

See the MariaDB Knowledgebase at https://mariadb.com/kb

Please report any problems at https://mariadb.org/jira

The latest information about MariaDB is available at https://mariadb.org/.

Consider joining MariaDB's strong and vibrant community:
https://mariadb.org/get-involved/

---> 13:44:30     Starting MySQL server with disabled networking ...
---> 13:44:30     Waiting for MySQL to start ...
/usr/libexec/mysqld: Deprecated program name. It will be removed in a future release, use '/usr/libexec/mariadbd' instead
2025-08-21 13:44:30 0 [Note] Starting MariaDB 11.8.3-MariaDB source revision b565b3e7e041c480fd8013e3beec6b99544d6bf8 server_uid zw0kt7UZqSetyyfmKEbz/i3k+LY= as process 58
2025-08-21 13:44:30 0 [ERROR] InnoDB: innodb_page_size=16384 requires innodb_buffer_pool_size >= 6 MiB current 5 MiB
2025-08-21 13:44:30 0 [ERROR] Plugin 'InnoDB' registration as a STORAGE ENGINE failed.
2025-08-21 13:44:30 0 [Note] Plugin 'FEEDBACK' is disabled.
2025-08-21 13:44:30 0 [Note] Plugin 'wsrep-provider' is disabled.
2025-08-21 13:44:30 0 [ERROR] Unknown/unsupported storage engine: InnoDB
2025-08-21 13:44:30 0 [ERROR] Aborting
Test for image 'quay.io/fedora/mariadb-118:11.8' FAILED (exit code: 1)
    Created container 98dfb064f82c5dd9498388cc266072c050e86daedefef0707b706a38f7e60c1d
  Testing MySQL connection to 10.88.0.92...
    Trying to connect.... FAIL
  Giving up: Failed to connect.
Error: no such object: "testpass2"
  Container finised with exit code .
Logs:
=> sourcing 20-validate-variables.sh ...
=> sourcing 25-validate-replication-variables.sh ...
=> sourcing 30-base-config.sh ...
---> 13:44:32     Processing basic MySQL configuration files ...
=> sourcing 60-replication-config.sh ...
=> sourcing 70-s2i-config.sh ...
---> 13:44:32     Processing additional arbitrary  MySQL configuration provided by s2i ...
=> sourcing 40-paas.cnf ...
=> sourcing 50-my-tuning.cnf ...
---> 13:44:32     Starting MySQL server with disabled networking ...
---> 13:44:32     Waiting for MySQL to start ...
/usr/libexec/mysqld: Deprecated program name. It will be removed in a future release, use '/usr/libexec/mariadbd' instead
2025-08-21 13:44:32 0 [Note] Starting MariaDB 11.8.3-MariaDB source revision b565b3e7e041c480fd8013e3beec6b99544d6bf8 server_uid PCi+RJyCwaDPfXL6I+4uNcJ2nvY= as process 20
2025-08-21 13:44:32 0 [ERROR] InnoDB: innodb_page_size=16384 requires innodb_buffer_pool_size >= 6 MiB current 5 MiB
2025-08-21 13:44:32 0 [ERROR] Plugin 'InnoDB' registration as a STORAGE ENGINE failed.
2025-08-21 13:44:32 0 [Note] Plugin 'FEEDBACK' is disabled.
2025-08-21 13:44:32 0 [Note] Plugin 'wsrep-provider' is disabled.
2025-08-21 13:44:32 0 [ERROR] Unknown/unsupported storage engine: InnoDB
2025-08-21 13:44:32 0 [ERROR] Aborting
Test for image 'quay.io/fedora/mariadb-118:11.8' FAILED (exit code: 1)
mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead
ERROR 2002 (HY000): Can't connect to local server through socket '/var/lib/mysql/mysql.sock' (2)
-----------------------------------------------

@FaramosCZ PTAL and help @ndavidova

ndavidova · 2025-08-27T09:35:32Z

[test]

ndavidova · 2025-08-27T09:48:06Z

[test]

phracek

Thanks for bringing new Fedora mariadb-container image to the Fedora land.
One note. As we do not build C9S, or C10S. Please remove it from build-and-push.yaml action.

I will look on INNODB_BUFFER_POOL_SIZE in detail.

.github/workflows/build-and-push.yml

phracek

Please update also file 40-datadir-action.sh that contains some checks.

Like here: https://github.com/sclorg/mariadb-container/blob/master/root-common/usr/share/container-scripts/mysql/init/40-datadir-action.sh especially https://github.com/sclorg/mariadb-container/blob/master/root-common/usr/share/container-scripts/mysql/init/40-datadir-action.sh#L62

It would be nice to also update https://github.com/sclorg/mariadb-container/blob/master/root-common/usr/share/container-scripts/mysql/init/40-datadir-action.sh#L1
@hhorak can may be help you a little bit more, as he is MariaDB database expert in Red Hat :)

ndavidova · 2025-08-28T10:24:34Z

[test]

phracek · 2025-08-28T10:52:20Z

Let's re-run test and innodb was increased.

[test]

ndavidova · 2025-09-01T06:13:57Z

[test]

FaramosCZ

c8s, rhel8 and their related exclude files are neither expected to be copied over, nor edited or created for MariaDB 11.8.

11.8/Dockerfile.c8s

phracek · 2025-09-01T12:34:47Z

[test]

phracek · 2025-09-01T14:30:53Z

It is a really BIG progress.
Only one error here:

-----------------------------------------------
Running test run_ssl_test (starting at 2025-09-01 14:24:12+00:00) ... 
-----------------------------------------------
  Testing ssl usage
.......+++++++++++++++++++++++++++++++++++++++*..........+..+.+.....+......+....+......+.....+.+..+++++++++++++++++++++++++++++++++++++++*...+....+...+.....+......+.+......+..+.......+.........+...........+...+.+..+....+...............+...+......+...........+....+......+...+....................+.......+......+..+...............+.+..+..........+.....+....+...........+..........+..+.+..+....+.........+.....+.++++++
..+.....+.+..+.......+...+..+............+...+..................+...+++++++++++++++++++++++++++++++++++++++*.....+...+...+..+.......+...+...+........+.+.....+.........+.......+..+...+...+...............+......+.+..+.+......+++++++++++++++++++++++++++++++++++++++*.+....+..+.........+....+..+.............+......+.........+..........................+.......+..+.+.........+...++++++
-----
    Created container 6208f6881101e1ad6ea0167c19cd431a2daf97504ffcc6fee75a197f8f10e9ca
  Testing MySQL connection to 10.88.0.144...
    Trying to connect....... OK
  Success!
mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead
ERROR 2026 (HY000): TLS/SSL error: Hostname verification failed
  FAIL!
mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead
ERROR 2026 (HY000): TLS/SSL error: Hostname verification failed
Test for image 'quay.io/fedora/mariadb-118:11.8' FAILED (exit code: 1)

ndavidova · 2025-09-02T12:23:27Z

[test]

FaramosCZ · 2025-09-11T12:48:59Z

I am now doing a review regarding the GIT quality:

1 to 4 fixed, thanks !

I'm still not satisfied with the justification of the Increase innodb buffer pool size commit.
I assume there is some equation how to compute the minimal amount required.
Please make the computation in the commit message so it is auditable, and also link to the upstream documentation where the computation is described.

New issue appeared - the two last commits are already present in the origin.
Bump common from 048d05c to 199f500 and Bump common from 199f500 to dc69f42 please rebase on top of them instead.

test/run

phracek · 2025-09-11T13:37:28Z

[test]

phracek

LGTM . Thanks for bringing this new container to our upstream repository. Great.

phracek · 2025-09-11T14:01:32Z

/auto-merge

Let's get merge it automatically.

Observed error: [ERROR] InnoDB: innodb_page_size=16384 requires innodb_buffer_pool_size >= 6 MiB current 5 MiB Pool size was increased from 5MiB to 6MiB

Remove brakes. Co-authored-by: Pavol Sloboda <127213124+PavolSloboda@users.noreply.github.com>

phracek · 2025-09-12T09:37:11Z

[test]

FaramosCZ · 2025-09-12T11:56:56Z

⚠️ @phracek you merged an unfinished PR into production.

The changes haven't passed my review.

Commits 6bc39db and f3fc8b1 should not be merged.

Neither they are complete nor auditable correct.

Can you please force remove them from production and make a standalone PR out of them, so we can resolve their remaining issues there ?

phracek · 2025-09-12T12:02:38Z

We can fix it by other PR.

FaramosCZ · 2025-09-12T13:23:43Z

I strongly suggest we employ more careful approach @phracek

There was no need to rush the PR
We have neither external nor internal deadline that won't allow it t be worked for another week. Or a month.
We now have unfinished commits in production, that I disputed not only for the formal deficiencies, but primarily because of the functionality and correctness of the code itself.
You merged the code even though there was an actual open review requesting changes.
Do you believe this is the best way we can cooperate on delivering high quality work?
As the MariaDB / MySQL subject matter expert, I hoped to have some say in what I believe is an acceptable solution and what is not, regarding at least the DB behavior itself.
Merging through unresolved reviews without a good justification send an uncomfortable message to the reviewers about how much you (don´t) value their effort.
We are fortunate to have new contributors, like Nikola, around.
It is especially important to care about teaching them correct habits, and make them familiar with doing the work the right way. Hasty Friday merges are quite the opposite of the values we wish to display, especially in PRs that are no way in a hurry.

I am happy to do hundred rounds of a review, if it gives value to the assignee.

While it seems that we can fix the potential issues later, it's pretty hard to fix low quality commit messages. When someone comes tomorrow, asking why you selected that exact value for buffer pool size, or where the computation comes from what will you tell them?

The code one writes is often other people responsibility later.
That's why it's so important to learn to create high quality code and commit messages, and why reviews from different people brings value that single pair of eyes can possibly not.

--

Would you like to reconsider removing the unfinished commits, if we haven't yet have a production build from the content?

What is your opinion on implementing a guideline for this organization, to require all open questions and requests for changes to be at least answered with justification, before moving forward leaving them unresolved?

github-actions bot added the pr/missing-review label Aug 21, 2025

github-actions bot added the pr/failing-ci label Aug 21, 2025

phracek requested changes Aug 25, 2025

View reviewed changes

github-actions bot added pr/changes-requested and removed pr/missing-review pr/failing-ci labels Aug 25, 2025

github-actions bot added the pr/failing-ci label Aug 27, 2025

phracek requested changes Aug 27, 2025

View reviewed changes

.github/workflows/build-and-push.yml Outdated Show resolved Hide resolved

phracek requested changes Aug 28, 2025

View reviewed changes

github-actions bot removed the pr/failing-ci label Aug 28, 2025

ndavidova force-pushed the master branch from 616bae1 to e0f1029 Compare August 28, 2025 10:23

github-actions bot added the pr/failing-ci label Aug 28, 2025

github-actions bot removed the pr/failing-ci label Aug 29, 2025

github-actions bot added the pr/failing-ci label Sep 1, 2025

FaramosCZ self-requested a review September 1, 2025 09:56

FaramosCZ assigned ndavidova Sep 1, 2025

FaramosCZ requested changes Sep 1, 2025

View reviewed changes

11.8/Dockerfile.c8s Outdated Show resolved Hide resolved

github-actions bot removed the pr/failing-ci label Sep 1, 2025

PavolSloboda reviewed Sep 11, 2025

View reviewed changes

test/run Outdated Show resolved Hide resolved

phracek approved these changes Sep 11, 2025

View reviewed changes

phracek added the READY-to-MERGE label Sep 11, 2025

github-actions bot added pr/needs-manual-merge and removed pr/failing-ci pr/changes-requested labels Sep 11, 2025

phracek removed the pr/needs-manual-merge label Sep 11, 2025

github-actions bot added the pr/needs-manual-merge label Sep 11, 2025

phracek removed the READY-to-MERGE label Sep 12, 2025

ndavidova and others added 10 commits September 12, 2025 09:52

Move 10.11 -> 11.8 to keep history

ad14711

Add 10.11 (copy of 11.8)

201d763

Remove c8s, rhel8 Dockerfiles, exclude files

9b54b6c

Update 11.8 Dockerfiles

3673c1e

Add exclude files

1311a17

Add 11.8 to Makefile

56a4535

Update build-and-push.yml to include 11.8

242a134

Include mariadb 11.8 in checks

e56a360

Increase innodb buffer pool size

6bc39db

Observed error: [ERROR] InnoDB: innodb_page_size=16384 requires innodb_buffer_pool_size >= 6 MiB current 5 MiB Pool size was increased from 5MiB to 6MiB

Add --disable-ssl-verify-server-cert for MariaDB >=11.4

f3fc8b1

Remove brakes. Co-authored-by: Pavol Sloboda <127213124+PavolSloboda@users.noreply.github.com>

ndavidova force-pushed the master branch from 3b6ef58 to f3fc8b1 Compare September 12, 2025 07:54

github-actions bot added the pr/failing-ci label Sep 12, 2025

phracek merged commit 3e08819 into sclorg:master Sep 12, 2025
12 checks passed

phracek mentioned this pull request Sep 17, 2025

Followup PR with 288 #293

Closed

Comments

Conversation

ndavidova commented Aug 21, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request validation

Failed

Success

Uh oh!

phracek commented Aug 21, 2025

Uh oh!

github-actions bot commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Farm results

Uh oh!

phracek left a comment

Choose a reason for hiding this comment

Uh oh!

phracek commented Aug 25, 2025

Uh oh!

ndavidova commented Aug 27, 2025

Uh oh!

ndavidova commented Aug 27, 2025

Uh oh!

phracek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

phracek left a comment

Choose a reason for hiding this comment

Uh oh!

ndavidova commented Aug 28, 2025

Uh oh!

phracek commented Aug 28, 2025

Uh oh!

ndavidova commented Sep 1, 2025

Uh oh!

FaramosCZ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

phracek commented Sep 1, 2025

Uh oh!

phracek commented Sep 1, 2025

Uh oh!

ndavidova commented Sep 2, 2025

Uh oh!

FaramosCZ commented Sep 11, 2025

Uh oh!

Uh oh!

phracek commented Sep 11, 2025

Uh oh!

phracek left a comment

Choose a reason for hiding this comment

Uh oh!

phracek commented Sep 11, 2025

Uh oh!

phracek commented Sep 12, 2025

Uh oh!

Uh oh!

FaramosCZ commented Sep 12, 2025

Uh oh!

phracek commented Sep 12, 2025

Uh oh!

FaramosCZ commented Sep 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ndavidova commented Aug 21, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Aug 21, 2025 •

edited

Loading

github-actions bot commented Aug 21, 2025 •

edited

Loading